github/msft-calculator
1
0
Fork 0
mirror of https://github.com/Microsoft/calculator.git synced 2025-08-22 14:13:30 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

- Move comment about pch use to pch for CalcManager.

Browse source
This commit is contained in:
Daniel Belcher 2019-04-05 11:59:08 -07:00
commit 8279df69b9
2 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
CONTRIBUTING.md
View file

@ -44,12 +44,6 @@ the code. Please attempt to match the style of surrounding code as much as possi
components, prefer the patterns described in the [C++ core guidelines](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines) components, prefer the patterns described in the [C++ core guidelines](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)
and the [modern C++/WinRT language projections](https://docs.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/). and the [modern C++/WinRT language projections](https://docs.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/).
The projects in this codebase typically make use of precompiled headers (pch.h). When it is necessary to include a
system header, please include it in the pch.h for the relevant project. For the CalcManager project specifically,
the project should be able to be compiled with or without a precompiled header in-order to support other toolsets
besides MSVC. For this project, make sure that the relevant source file includes all headers it needs, but then also
add the system headers to the pch so that MSVC users see the performance benefit.
### Testing ### Testing
Your change should include tests to verify new functionality wherever possible. Code should be Your change should include tests to verify new functionality wherever possible. Code should be
structured so that it can be unit tested independently of the UI. [Manual test cases](docs/ManualTests.md) structured so that it can be unit tested independently of the UI. [Manual test cases](docs/ManualTests.md)

5
src/CalcManager/pch.h
View file

@ -3,6 +3,11 @@
#pragma once #pragma once
// The CalcManager project should be able to be compiled with or without a precompiled header
// in - order to support other toolchains besides MSVC. When adding new system headers, make sure
// that the relevant source file includes all headers it needs, but then also add the system headers
// here so that MSVC users see the performance benefit.
#include <algorithm> #include <algorithm>
#include <array> #include <array>
#include <cassert> #include <cassert>