From c558123cb2994aa27abad378ed19d42d0cb24b67 Mon Sep 17 00:00:00 2001 From: Stephanie Anderl <46726333+sanderl@users.noreply.github.com> Date: Mon, 11 Feb 2019 11:21:42 -0800 Subject: [PATCH 01/10] Added Bug Report and Feature Request Issue Templates Updated the default Bug Report template to customize the Device and Application information section. The Feature Request template is the default one. --- .github/ISSUE_TEMPLATE/bug_report.md | 32 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 20 ++++++++++++++ 2 files changed, 52 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..17838a21 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,32 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: '' +assignees: '' + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Device and Application Information (please complete the following information):** + - OS Build Number: + - Architecture: + - Application Version Number: + +**Additional context** +Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 00000000..bbcbbe7d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: '' +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. From 6afad0b7da8b8e5559eb5cdb2966b09d703e8fc8 Mon Sep 17 00:00:00 2001 From: Stephanie Anderl <46726333+sanderl@users.noreply.github.com> Date: Mon, 11 Feb 2019 11:35:28 -0800 Subject: [PATCH 02/10] Updated feature_request.md to link to NewFeatureRequest.md --- .github/ISSUE_TEMPLATE/feature_request.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index bbcbbe7d..7feb6992 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -7,6 +7,9 @@ assignees: '' --- +**Please describe your feature request.** +*For more information see the [NewFeatureProcess.md](../../docs/NewFeatureProcess.md)* + **Is your feature request related to a problem? Please describe.** A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] From 82cfa338d4b2c009cb821bc7b5f332abb80de0cd Mon Sep 17 00:00:00 2001 From: Stephanie Anderl <46726333+sanderl@users.noreply.github.com> Date: Wed, 13 Feb 2019 10:57:13 -0800 Subject: [PATCH 03/10] Added a before filing section and updated the device info section to inlcude the powershell commands to get the info --- .github/ISSUE_TEMPLATE/bug_report.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 17838a21..3000313f 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -6,6 +6,9 @@ labels: '' assignees: '' --- +**Before filing a bug** +- Ensure the bug reproduces on the latest version of the app. +- Search existing issues and make sure this issue is not already filed. **Describe the bug** A clear and concise description of what the bug is. @@ -28,5 +31,10 @@ If applicable, add screenshots to help explain your problem. - Architecture: - Application Version Number: + Run the following commands in Powershell and copy/paste the output. + - OS Build: "$([Environment]::OSVersion.Version)" + - Architecture: "$((Get-AppxPackage -Name Microsoft.WindowsCalculator).Architecture)" + - Application Version: "$((Get-AppxPackage -Name Microsoft.WindowsCalculator).Version)" + **Additional context** Add any other context about the problem here. From c4c0aa708c501023a4d565615b4bd1b4b5e223fe Mon Sep 17 00:00:00 2001 From: Stephanie Anderl <46726333+sanderl@users.noreply.github.com> Date: Thu, 14 Feb 2019 14:12:33 -0800 Subject: [PATCH 04/10] Shortened the headers, fixed the contributing link and made placeholder description text a comment --- .../PULL_REQUEST_TEMPLATE/pull_request_template.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index 82f1599f..aa35bb26 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,15 +1,15 @@ # Fixes #. -## Description of the changes in this pull request: +## Description of the changes: - - - -## How this pull request was validated: -### Review [Contributing.md](../Contributing.md) and ensure all contributing requirements are met. -### Specify how you tested your changes (i.e. manual/ad-hoc testing, automated testing, new automated tests added) -- +## How changes were validated: + +- - - -@Microsoft/calculator-team From e0ae35560d9e6ed825e58198a27df1a7dcd4d52d Mon Sep 17 00:00:00 2001 From: Stephanie Anderl <46726333+sanderl@users.noreply.github.com> Date: Thu, 14 Feb 2019 14:31:22 -0800 Subject: [PATCH 05/10] updated issue templates to put placeholder text in comments --- .github/ISSUE_TEMPLATE/bug_report.md | 22 +++++++++++----------- .github/ISSUE_TEMPLATE/feature_request.md | 10 +++++----- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 3000313f..1ef22a72 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -6,35 +6,35 @@ labels: '' assignees: '' --- -**Before filing a bug** + **Describe the bug** -A clear and concise description of what the bug is. + -**To Reproduce** -Steps to reproduce the behavior: +**Steps To Reproduce** + **Expected behavior** -A clear and concise description of what you expected to happen. + **Screenshots** -If applicable, add screenshots to help explain your problem. + **Device and Application Information (please complete the following information):** - OS Build Number: - Architecture: - Application Version Number: - Run the following commands in Powershell and copy/paste the output. + **Additional context** -Add any other context about the problem here. + diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 7feb6992..f5b947eb 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -8,16 +8,16 @@ assignees: '' --- **Please describe your feature request.** -*For more information see the [NewFeatureProcess.md](../../docs/NewFeatureProcess.md)* + **Is your feature request related to a problem? Please describe.** -A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + **Describe the solution you'd like** -A clear and concise description of what you want to happen. + **Describe alternatives you've considered** -A clear and concise description of any alternative solutions or features you've considered. + **Additional context** -Add any other context or screenshots about the feature request here. + From 99a60dddc5a4d1af4374b92232ea8c94afa95cad Mon Sep 17 00:00:00 2001 From: Stephanie Anderl <46726333+sanderl@users.noreply.github.com> Date: Wed, 20 Feb 2019 10:05:21 -0800 Subject: [PATCH 06/10] removed 'the' before the link to the NewFeatureRequest.md link --- .github/ISSUE_TEMPLATE/feature_request.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index f5b947eb..035dc234 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -8,7 +8,7 @@ assignees: '' --- **Please describe your feature request.** - + **Is your feature request related to a problem? Please describe.** From ba4bf407f28a6b48d7fe215afaa72a8a4ee14e69 Mon Sep 17 00:00:00 2001 From: Stephanie Anderl <46726333+sanderl@users.noreply.github.com> Date: Wed, 20 Feb 2019 10:13:33 -0800 Subject: [PATCH 07/10] reduced header size --- .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index aa35bb26..b50c909a 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,11 +1,12 @@ -# Fixes #. +## Fixes #. -## Description of the changes: + +### Description of the changes: - - - -## How changes were validated: +### How changes were validated: From 2e18f6f4774d7e4c14e5707f4b2d885c4e872713 Mon Sep 17 00:00:00 2001 From: Josh Koon <45607479+joshkoon@users.noreply.github.com> Date: Wed, 20 Feb 2019 11:07:32 -0800 Subject: [PATCH 08/10] Move RADIX_TYPE enum into its own header (#25) This change moves the RADIX_TYPE enum into its own header. This resolves a compilation error and reduces the dependency graph by allowing RadixToStringConverter to include just the enum header rather than the entire CalcEngine header. Change verified by ensuring Calculator build locally. --- src/CalcManager/CalcManager.vcxproj | 1 + src/CalcManager/CalcManager.vcxproj.filters | 3 +++ src/CalcManager/Header Files/CalcEngine.h | 10 +--------- src/CalcManager/Header Files/Number.h | 2 +- src/CalcManager/Header Files/RadixType.h | 13 +++++++++++++ .../Converters/RadixToStringConverter.cpp | 2 +- 6 files changed, 20 insertions(+), 11 deletions(-) create mode 100644 src/CalcManager/Header Files/RadixType.h diff --git a/src/CalcManager/CalcManager.vcxproj b/src/CalcManager/CalcManager.vcxproj index 9a9ea380..868abfe9 100644 --- a/src/CalcManager/CalcManager.vcxproj +++ b/src/CalcManager/CalcManager.vcxproj @@ -279,6 +279,7 @@ + diff --git a/src/CalcManager/CalcManager.vcxproj.filters b/src/CalcManager/CalcManager.vcxproj.filters index 7c4ad536..14a28e88 100644 --- a/src/CalcManager/CalcManager.vcxproj.filters +++ b/src/CalcManager/CalcManager.vcxproj.filters @@ -161,5 +161,8 @@ Header Files + + Header Files + \ No newline at end of file diff --git a/src/CalcManager/Header Files/CalcEngine.h b/src/CalcManager/Header Files/CalcEngine.h index 72e21ac3..b5527608 100644 --- a/src/CalcManager/Header Files/CalcEngine.h +++ b/src/CalcManager/Header Files/CalcEngine.h @@ -20,6 +20,7 @@ #include "../Command.h" #include "../CalculatorVector.h" #include "../ExpressionCommand.h" +#include "RadixType.h" #include "History.h" // for History Collector #include "CalcInput.h" #include "ICalcDisplay.h" @@ -38,15 +39,6 @@ enum eNUM_WIDTH { typedef enum eNUM_WIDTH NUM_WIDTH; static constexpr size_t NUM_WIDTH_LENGTH = 4; -// This is expected to be in same order as IDM_HEX, IDM_DEC, IDM_OCT, IDM_BIN -enum eRADIX_TYPE { - HEX_RADIX, - DEC_RADIX, - OCT_RADIX, - BIN_RADIX -}; -typedef enum eRADIX_TYPE RADIX_TYPE; - namespace CalculationManager { class IResourceProvider; diff --git a/src/CalcManager/Header Files/Number.h b/src/CalcManager/Header Files/Number.h index 061d6190..f832a840 100644 --- a/src/CalcManager/Header Files/Number.h +++ b/src/CalcManager/Header Files/Number.h @@ -2,7 +2,7 @@ #pragma once -#include "RatPack/ratpak.h" +#include "Ratpack/ratpak.h" namespace CalcEngine { diff --git a/src/CalcManager/Header Files/RadixType.h b/src/CalcManager/Header Files/RadixType.h new file mode 100644 index 00000000..3f7f2456 --- /dev/null +++ b/src/CalcManager/Header Files/RadixType.h @@ -0,0 +1,13 @@ +// Copyright (c) Microsoft Corporation. All rights reserved. +// Licensed under the MIT License. + +#pragma once + +// This is expected to be in same order as IDM_HEX, IDM_DEC, IDM_OCT, IDM_BIN +enum eRADIX_TYPE { + HEX_RADIX, + DEC_RADIX, + OCT_RADIX, + BIN_RADIX +}; +typedef enum eRADIX_TYPE RADIX_TYPE; diff --git a/src/Calculator/Converters/RadixToStringConverter.cpp b/src/Calculator/Converters/RadixToStringConverter.cpp index 053800e8..d8c878da 100644 --- a/src/Calculator/Converters/RadixToStringConverter.cpp +++ b/src/Calculator/Converters/RadixToStringConverter.cpp @@ -3,7 +3,7 @@ #include "pch.h" #include "RadixToStringConverter.h" -#include "CalcManager/Header Files/CalcEngine.h" +#include "CalcManager/Header Files/RadixType.h" #include "CalcViewModel/Common/AppResourceProvider.h" using namespace Platform; From 73e685fe53925a22c5bb4513ede1facd2221112d Mon Sep 17 00:00:00 2001 From: Stephanie Anderl <46726333+sanderl@users.noreply.github.com> Date: Wed, 20 Feb 2019 14:25:01 -0800 Subject: [PATCH 09/10] Added space after NewFeatureRequest.md link to make it easier to copy --- .github/ISSUE_TEMPLATE/feature_request.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 035dc234..a2641fa8 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -8,7 +8,7 @@ assignees: '' --- **Please describe your feature request.** - + **Is your feature request related to a problem? Please describe.** From 23a3507253bfd93f083a912ad6af8586bf2f86b4 Mon Sep 17 00:00:00 2001 From: Stephanie Anderl <46726333+sanderl@users.noreply.github.com> Date: Wed, 20 Feb 2019 14:47:36 -0800 Subject: [PATCH 10/10] copied pull_request_template.md to .github folder --- .github/pull_request_template.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..b50c909a --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,16 @@ +## Fixes #. + + +### Description of the changes: +- +- +- + +### How changes were validated: + +- +- +- +