diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 035dc234..a2641fa8 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -8,7 +8,7 @@ assignees: '' --- **Please describe your feature request.** - + **Is your feature request related to a problem? Please describe.** diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index 82f1599f..b50c909a 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,15 +1,16 @@ -# Fixes #. +## Fixes #. -## Description of the changes in this pull request: + +### Description of the changes: - - - -## How this pull request was validated: -### Review [Contributing.md](../Contributing.md) and ensure all contributing requirements are met. -### Specify how you tested your changes (i.e. manual/ad-hoc testing, automated testing, new automated tests added) -- +### How changes were validated: + +- - - -@Microsoft/calculator-team diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..b50c909a --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,16 @@ +## Fixes #. + + +### Description of the changes: +- +- +- + +### How changes were validated: + +- +- +- + diff --git a/src/CalcManager/CalcManager.vcxproj b/src/CalcManager/CalcManager.vcxproj index 9a9ea380..868abfe9 100644 --- a/src/CalcManager/CalcManager.vcxproj +++ b/src/CalcManager/CalcManager.vcxproj @@ -279,6 +279,7 @@ + diff --git a/src/CalcManager/CalcManager.vcxproj.filters b/src/CalcManager/CalcManager.vcxproj.filters index 7c4ad536..14a28e88 100644 --- a/src/CalcManager/CalcManager.vcxproj.filters +++ b/src/CalcManager/CalcManager.vcxproj.filters @@ -161,5 +161,8 @@ Header Files + + Header Files + \ No newline at end of file diff --git a/src/CalcManager/Header Files/CalcEngine.h b/src/CalcManager/Header Files/CalcEngine.h index 72e21ac3..b5527608 100644 --- a/src/CalcManager/Header Files/CalcEngine.h +++ b/src/CalcManager/Header Files/CalcEngine.h @@ -20,6 +20,7 @@ #include "../Command.h" #include "../CalculatorVector.h" #include "../ExpressionCommand.h" +#include "RadixType.h" #include "History.h" // for History Collector #include "CalcInput.h" #include "ICalcDisplay.h" @@ -38,15 +39,6 @@ enum eNUM_WIDTH { typedef enum eNUM_WIDTH NUM_WIDTH; static constexpr size_t NUM_WIDTH_LENGTH = 4; -// This is expected to be in same order as IDM_HEX, IDM_DEC, IDM_OCT, IDM_BIN -enum eRADIX_TYPE { - HEX_RADIX, - DEC_RADIX, - OCT_RADIX, - BIN_RADIX -}; -typedef enum eRADIX_TYPE RADIX_TYPE; - namespace CalculationManager { class IResourceProvider; diff --git a/src/CalcManager/Header Files/Number.h b/src/CalcManager/Header Files/Number.h index 061d6190..f832a840 100644 --- a/src/CalcManager/Header Files/Number.h +++ b/src/CalcManager/Header Files/Number.h @@ -2,7 +2,7 @@ #pragma once -#include "RatPack/ratpak.h" +#include "Ratpack/ratpak.h" namespace CalcEngine { diff --git a/src/CalcManager/Header Files/RadixType.h b/src/CalcManager/Header Files/RadixType.h new file mode 100644 index 00000000..3f7f2456 --- /dev/null +++ b/src/CalcManager/Header Files/RadixType.h @@ -0,0 +1,13 @@ +// Copyright (c) Microsoft Corporation. All rights reserved. +// Licensed under the MIT License. + +#pragma once + +// This is expected to be in same order as IDM_HEX, IDM_DEC, IDM_OCT, IDM_BIN +enum eRADIX_TYPE { + HEX_RADIX, + DEC_RADIX, + OCT_RADIX, + BIN_RADIX +}; +typedef enum eRADIX_TYPE RADIX_TYPE; diff --git a/src/Calculator/Converters/RadixToStringConverter.cpp b/src/Calculator/Converters/RadixToStringConverter.cpp index 053800e8..d8c878da 100644 --- a/src/Calculator/Converters/RadixToStringConverter.cpp +++ b/src/Calculator/Converters/RadixToStringConverter.cpp @@ -3,7 +3,7 @@ #include "pch.h" #include "RadixToStringConverter.h" -#include "CalcManager/Header Files/CalcEngine.h" +#include "CalcManager/Header Files/RadixType.h" #include "CalcViewModel/Common/AppResourceProvider.h" using namespace Platform;