diff --git a/src/CalcViewModel/Common/NavCategory.cpp b/src/CalcViewModel/Common/NavCategory.cpp index 3d0ab43e..7c89c6a4 100644 --- a/src/CalcViewModel/Common/NavCategory.cpp +++ b/src/CalcViewModel/Common/NavCategory.cpp @@ -42,7 +42,6 @@ static constexpr int PRESSURE_ID = 14; static constexpr int ANGLE_ID = 15; static constexpr int CURRENCY_ID = 16; static constexpr int GRAPHING_ID = 17; -static constexpr int SETTINGS_ID = 18; // ^^^ THESE CONSTANTS SHOULD NEVER CHANGE ^^^ wchar_t* towchar_t(int number) @@ -299,16 +298,6 @@ static const list s_categoryManifest = [] { MyVirtualKey::None, nullptr, SUPPORTS_NEGATIVE, - true }, - NavCategoryInitializer{ ViewMode::Settings, - SETTINGS_ID, - L"Settings", - L"CategoryName_Settings", - L"\uE713", - CategoryGroupType::None, - MyVirtualKey::None, - nullptr, - false, true } }); return res; }(); @@ -390,11 +379,6 @@ bool NavCategory::IsConverterViewMode(ViewMode mode) return IsModeInCategoryGroup(mode, CategoryGroupType::Converter); } -bool NavCategory::IsSettingsViewMode(ViewMode mode) -{ - return mode == ViewMode::Settings; -} - bool NavCategory::IsModeInCategoryGroup(ViewMode mode, CategoryGroupType type) { auto iter = find_if(begin(s_categoryManifest), end(s_categoryManifest), [mode, type](const NavCategoryInitializer& initializer) { diff --git a/src/CalcViewModel/Common/NavCategory.h b/src/CalcViewModel/Common/NavCategory.h index d1498ced..b7c46057 100644 --- a/src/CalcViewModel/Common/NavCategory.h +++ b/src/CalcViewModel/Common/NavCategory.h @@ -45,8 +45,7 @@ namespace CalculatorApp Pressure = 14, Angle = 15, Currency = 16, - Graphing = 17, - Settings = 18 + Graphing = 17 }; public @@ -140,7 +139,6 @@ namespace CalculatorApp static bool IsGraphingCalculatorViewMode(ViewMode mode); static bool IsDateCalculatorViewMode(ViewMode mode); static bool IsConverterViewMode(ViewMode mode); - static bool IsSettingsViewMode(ViewMode mode); static Platform::String ^ GetFriendlyName(ViewMode mode); static Platform::String ^ GetNameResourceKey(ViewMode mode); diff --git a/src/Calculator/Resources/en-US/Resources.resw b/src/Calculator/Resources/en-US/Resources.resw index c423b875..87fe5cd9 100644 --- a/src/Calculator/Resources/en-US/Resources.resw +++ b/src/Calculator/Resources/en-US/Resources.resw @@ -4726,4 +4726,12 @@ You'll see your changes the next time you start the app. Notice when the user change the theme. + + Back + This is the tool tip for the back button + + + Settings + Text for the "Settings" header + \ No newline at end of file diff --git a/src/Calculator/SettingsPage.xaml b/src/Calculator/SettingsPage.xaml index 56963763..8b538696 100644 --- a/src/Calculator/SettingsPage.xaml +++ b/src/Calculator/SettingsPage.xaml @@ -1,17 +1,24 @@ - + - + + + + + - + + + + + + +