From 1ecf431ea352cad894b993dd620e6233f6d6ec93 Mon Sep 17 00:00:00 2001
From: pi1024e <49824824+pi1024e@users.noreply.github.com>
Date: Fri, 14 Feb 2020 15:52:58 -0500
Subject: [PATCH] No need to make an enum variable if it is either one of two
 possibilities. (#1036)

Visibility variable holding collapsed but then turning into visible is unnecessary when one can return Visibility::Collapsed or Visibility::Visible.
---
 src/Calculator/Converters/VisibilityNegationConverter.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/Calculator/Converters/VisibilityNegationConverter.cpp b/src/Calculator/Converters/VisibilityNegationConverter.cpp
index a80c04fc..a4d5a33f 100644
--- a/src/Calculator/Converters/VisibilityNegationConverter.cpp
+++ b/src/Calculator/Converters/VisibilityNegationConverter.cpp
@@ -16,12 +16,11 @@ namespace CalculatorApp
         Object ^ VisibilityNegationConverter::Convert(Object ^ value, TypeName /*targetType*/, Object ^ /*parameter*/, String ^ /*language*/)
         {
             auto boxedVisibility = dynamic_cast<Box<Visibility> ^>(value);
-            Visibility visibility = Visibility::Collapsed;
             if (boxedVisibility != nullptr && boxedVisibility->Value == Visibility::Collapsed)
             {
-                visibility = Visibility::Visible;
+                return Visibility::Visible;
             }
-            return visibility;
+            return Visibility::Collapsed;
         }
 
         Object ^ VisibilityNegationConverter::ConvertBack(Object ^ value, TypeName targetType, Object ^ parameter, String ^ language)