From 172a3707220b948a2705889a5f671228b28701f6 Mon Sep 17 00:00:00 2001
From: Rose <83477269+AtariDreams@users.noreply.github.com>
Date: Thu, 22 Sep 2022 14:39:08 -0400
Subject: [PATCH] Replace HttpWebRequest with HttpClient (#1886)

HttpWebRequest is deprecated and it is trivial to ping using the replacement API.
---
 .../WindowsDriverLocalService.cs              | 36 ++++---------------
 1 file changed, 7 insertions(+), 29 deletions(-)

diff --git a/src/CalculatorUITestFramework/WindowsDriverLocalService.cs b/src/CalculatorUITestFramework/WindowsDriverLocalService.cs
index 16a21229..8841c6cb 100644
--- a/src/CalculatorUITestFramework/WindowsDriverLocalService.cs
+++ b/src/CalculatorUITestFramework/WindowsDriverLocalService.cs
@@ -18,6 +18,7 @@ using System;
 using System.Diagnostics;
 using System.IO;
 using System.Net;
+using System.Net.Http;
 using System.Runtime.CompilerServices;
 
 namespace CalculatorUITestFramework
@@ -143,11 +144,11 @@ namespace CalculatorUITestFramework
 
         private bool Ping()
         {
-            bool pinged = false;
-
             Uri status;
-
             Uri service = this.ServiceUrl;
+            HttpClient httpClient = new HttpClient();
+            httpClient.Timeout = this.InitializationTimeout;
+
             if (service.IsLoopback)
             {
                 status = new Uri("http://localhost:" + Convert.ToString(this.Port) + "/status");
@@ -156,32 +157,9 @@ namespace CalculatorUITestFramework
             {
                 status = new Uri(service + "/status");
             }
-
-            DateTime endTime = DateTime.Now.Add(this.InitializationTimeout);
-            while (!pinged & DateTime.Now < endTime)
-            {
-                HttpWebRequest request = (HttpWebRequest)HttpWebRequest.Create(status);
-                HttpWebResponse response = null;
-                try
-                {
-                    using (response = (HttpWebResponse)request.GetResponse())
-                    {
-                        pinged = true;
-                    }
-                }
-                catch (Exception)
-                {
-                    pinged = false;
-                }
-                finally
-                {
-                    if (response != null)
-                    {
-                        response.Close();
-                    }
-                }
-            }
-            return pinged;
+            
+            var httpResponse = httpClient.GetAsync(status);
+            return httpResponse.Result.IsSuccessStatusCode;
         }
     }
 }