github/msft-calculator
1
0
Fork 0
mirror of https://github.com/Microsoft/calculator.git synced 2025-08-22 06:13:14 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

- rename modrate in remrate

Browse source 
- add modrate (arithmetic modular)
- modify CalcEngine to use modrate in Normal and Scientific mode and remrate in Programmer mode
This commit is contained in:
Rudy Huyn 2019-03-30 03:22:03 -07:00
commit 0a69348b00
13 changed files with 188 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/CalcManager/CEngine/Rational.cpp
View file

@ -189,7 +189,7 @@ namespace CalcEngine
try
{
modrat(&lhsRat, rhsRat);
remrat(&lhsRat, rhsRat);
destroyrat(rhsRat);
}
catch (uint32_t error)

23
src/CalcManager/CEngine/RationalMath.cpp
View file

@ -387,3 +387,26 @@ Rational RationalMath::ATanh(Rational const& rat)
return result;
}
Rational RationalMath::Mod(Rational const& base, Rational const& n)
{
PRAT prat = base.ToPRAT();
PRAT pn = n.ToPRAT();
try
{
modrat(&prat, pn);
destroyrat(pn);
}
catch (uint32_t error)
{
destroyrat(prat);
destroyrat(pn);
throw(error);
}
auto res = Rational{ prat };
destroyrat(prat);
return res;
}

9
src/CalcManager/CEngine/scioper.cpp
View file

@ -112,9 +112,18 @@ CalcEngine::Rational CCalcEngine::DoOperation(int operation, CalcEngine::Rationa
}
else
{
if (m_fIntegerMode)
{
// Programmer mode
iFinalSign = iNumeratorSign;
result %= temp;
}
else
{
iFinalSign = iDenominatorSign;
result = Mod(result, temp);
}
}
if (m_fIntegerMode && iFinalSign == -1)
{

1
src/CalcManager/Header Files/RationalMath.h
View file

@ -13,6 +13,7 @@ namespace CalcEngine::RationalMath
Rational Pow(Rational const& base, Rational const& pow);
Rational Root(Rational const& base, Rational const& root);
Rational Fact(Rational const& rat);
Rational Mod(Rational const& base, Rational const& n);
Rational Exp(Rational const& rat);
Rational Log(Rational const& rat);

2
src/CalcManager/Ratpack/exp.cpp
View file

@ -408,7 +408,7 @@ void powratNumeratorDenominator(PRAT *px, PRAT y, uint32_t radix, int32_t precis
//---------------------------------------------------------------------------
void powratcomp(PRAT *px, PRAT y, uint32_t radix, int32_t precision)
{
int32_t sign = ((*px)->pp->sign * (*px)->pq->sign);
int32_t sign = SIGN(*px);
// Take the absolute value
(*px)->pp->sign = 1;

4
src/CalcManager/Ratpack/fact.cpp
View file

@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
//-----------------------------------------------------------------------------
@ -216,7 +216,7 @@ void factrat( PRAT *px, uint32_t radix, int32_t precision)
// Check for negative integers and throw an error.
if ( ( zerrat(frac) || ( LOGRATRADIX(frac) <= -precision) ) &&
( (*px)->pp->sign * (*px)->pq->sign == -1 ) )
( SIGN(*px) == -1 ) )
{
throw CALC_E_DOMAIN;
}

8
src/CalcManager/Ratpack/itrans.cpp
View file

@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
//-----------------------------------------------------------------------------
@ -96,7 +96,7 @@ void asinrat( PRAT *px, uint32_t radix, int32_t precision)
PRAT pret= nullptr;
PRAT phack= nullptr;
sgn = (*px)->pp->sign* (*px)->pq->sign;
sgn = SIGN(*px);
(*px)->pp->sign = 1;
(*px)->pq->sign = 1;
@ -206,7 +206,7 @@ void acosrat( PRAT *px, uint32_t radix, int32_t precision)
{
int32_t sgn;
sgn = (*px)->pp->sign*(*px)->pq->sign;
sgn = SIGN(*px);
(*px)->pp->sign = 1;
(*px)->pq->sign = 1;
@ -294,7 +294,7 @@ void atanrat( PRAT *px, uint32_t radix, int32_t precision)
int32_t sgn;
PRAT tmpx= nullptr;
sgn = (*px)->pp->sign * (*px)->pq->sign;
sgn = SIGN(*px);
(*px)->pp->sign = 1;
(*px)->pq->sign = 1;

53
src/CalcManager/Ratpack/logic.cpp
View file

@ -185,25 +185,26 @@ void boolnum( PNUMBER *pa, PNUMBER b, int func )
//-----------------------------------------------------------------------------
//
// FUNCTION: modrat
// FUNCTION: remrat
//
// ARGUMENTS: pointer to a rational a second rational.
//
// RETURN: None, changes pointer.
//
// DESCRIPTION: Does the rational equivalent of frac(*pa);
// DESCRIPTION: Calculate the remainder of *pa / b, equivalent of 'pa % b' in C;
// NOTE: produces a result that is either zero or has the same sign as the dividend.
//
//-----------------------------------------------------------------------------
void modrat( PRAT *pa, PRAT b )
void remrat(PRAT *pa, PRAT b)
{
PRAT tmp = nullptr;
if (zerrat(b))
{
throw CALC_E_INDEFINITE;
}
PRAT tmp = nullptr;
DUPRAT(tmp, b);
mulnumx(&((*pa)->pp), tmp->pq);
@ -216,3 +217,45 @@ void modrat( PRAT *pa, PRAT b )
destroyrat(tmp);
}
//-----------------------------------------------------------------------------
//
// FUNCTION: modrat
//
// ARGUMENTS: pointer to a rational a second rational.
//
// RETURN: None, changes pointer.
//
// DESCRIPTION: Calculate the remainder of *pa / b, equivalent of 'pa modulo b' in arithmetic
// NOTE: produces a result that is either zero or has the same sign as the divisor.
//
//-----------------------------------------------------------------------------
void modrat(PRAT *pa, PRAT b)
{
//contrary to remrat, modrat(a, 0) must return a
if (zerrat(b))
{
return;
}
PRAT tmp = nullptr;
DUPRAT(tmp, b);
auto needAdjust = (SIGN(*pa) == -1 ? (SIGN(b) == 1) : (SIGN(b) == -1));
mulnumx(&((*pa)->pp), tmp->pq);
mulnumx(&(tmp->pp), (*pa)->pq);
remnum(&((*pa)->pp), tmp->pp, BASEX);
mulnumx(&((*pa)->pq), tmp->pq);
if (needAdjust)
{
addrat(pa, b, BASEX);
}
// Get *pa back in the integer over integer form.
RENORMALIZE(*pa);
destroyrat(tmp);
}

4
src/CalcManager/Ratpack/ratpak.h
View file

@ -148,6 +148,9 @@ extern PRAT rat_min_i32;
#define LOGNUM2(pnum) ((pnum)->cdigit+(pnum)->exp)
#define LOGRAT2(prat) (LOGNUM2((prat)->pp)-LOGNUM2((prat)->pq))
// SIGN returns the sign of the rational
#define SIGN(prat) ((prat)->pp->sign*(prat)->pq->sign)
#if defined( DEBUG_RATPAK )
//-----------------------------------------------------------------------------
//
@ -423,6 +426,7 @@ extern void divnumx( _Inout_ PNUMBER *pa, _In_ PNUMBER b, int32_t precision);
extern void divrat( _Inout_ PRAT *pa, _In_ PRAT b, int32_t precision);
extern void fracrat( _Inout_ PRAT *pa , uint32_t radix, int32_t precision);
extern void factrat( _Inout_ PRAT *pa, uint32_t radix, int32_t precision);
extern void remrat(_Inout_ PRAT *pa, _In_ PRAT b);
extern void modrat(_Inout_ PRAT *pa, _In_ PRAT b);
extern void gcdrat( _Inout_ PRAT *pa, int32_t precision);
extern void intrat( _Inout_ PRAT *px, uint32_t radix, int32_t precision);

16
src/CalcManager/Ratpack/support.cpp
View file

@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
//----------------------------------------------------------------------------
@ -296,7 +296,7 @@ void intrat( PRAT *px, uint32_t radix, int32_t precision)
// Subtract the fractional part of the rational
PRAT pret = nullptr;
DUPRAT(pret,*px);
modrat( &pret, rat_one );
remrat( &pret, rat_one );
subrat( px, pret, precision);
destroyrat( pret );
@ -348,8 +348,7 @@ bool rat_ge( PRAT a, PRAT b, int32_t precision)
b->pp->sign *= -1;
addrat( &rattmp, b, precision);
b->pp->sign *= -1;
bool bret = ( zernum( rattmp->pp ) ||
rattmp->pp->sign * rattmp->pq->sign == 1 );
bool bret = ( zernum( rattmp->pp ) || SIGN(rattmp) == 1 );
destroyrat( rattmp );
return( bret );
}
@ -374,8 +373,7 @@ bool rat_gt( PRAT a, PRAT b, int32_t precision)
b->pp->sign *= -1;
addrat( &rattmp, b, precision);
b->pp->sign *= -1;
bool bret = ( !zernum( rattmp->pp ) &&
rattmp->pp->sign * rattmp->pq->sign == 1 );
bool bret = ( !zernum( rattmp->pp ) && SIGN(rattmp) == 1 );
destroyrat( rattmp );
return( bret );
}
@ -400,8 +398,7 @@ bool rat_le( PRAT a, PRAT b, int32_t precision)
b->pp->sign *= -1;
addrat( &rattmp, b, precision);
b->pp->sign *= -1;
bool bret = ( zernum( rattmp->pp ) ||
rattmp->pp->sign * rattmp->pq->sign == -1 );
bool bret = ( zernum( rattmp->pp ) || SIGN(rattmp) == -1 );
destroyrat( rattmp );
return( bret );
}
@ -426,8 +423,7 @@ bool rat_lt( PRAT a, PRAT b, int32_t precision)
b->pp->sign *= -1;
addrat( &rattmp, b, precision);
b->pp->sign *= -1;
bool bret = ( !zernum( rattmp->pp ) &&
rattmp->pp->sign * rattmp->pq->sign == -1 );
bool bret = ( !zernum( rattmp->pp ) && SIGN(rattmp) == -1 );
destroyrat( rattmp );
return( bret );
}

1
src/CalculatorUnitTests/CalculatorUnitTests.vcxproj
View file

@ -248,6 +248,7 @@
<ClCompile Include="Module.cpp" />
<ClCompile Include="MultiWindowUnitTests.cpp" />
<ClCompile Include="NavCategoryUnitTests.cpp" />
<ClCompile Include="RationalTest.cpp" />
<ClCompile Include="StandardViewModelUnitTests.cpp" />
<ClCompile Include="UnitConverterTest.cpp" />
<ClCompile Include="UnitConverterViewModelUnitTests.cpp" />

1
src/CalculatorUnitTests/CalculatorUnitTests.vcxproj.filters
View file

@ -29,6 +29,7 @@
<ClCompile Include="Mocks\CurrencyHttpClient.cpp">
<Filter>Mocks</Filter>
</ClCompile>
<ClCompile Include="RationalTest.cpp" />
</ItemGroup>
<ItemGroup>
<ClInclude Include="AsyncHelper.h" />

76
src/CalculatorUnitTests/RationalTest.cpp Normal file
View file

@ -0,0 +1,76 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
#include "pch.h"
#include <CppUnitTest.h>
#include "Header Files/Rational.h"
#include "Header Files/RationalMath.h"
using namespace CalcEngine;
using namespace CalcEngine::RationalMath;
using namespace Microsoft::VisualStudio::CppUnitTestFramework;
namespace RationalTests
{
TEST_CLASS(RationalTest)
{
public:
TEST_CLASS_INITIALIZE(CommonSetup)
{
ChangeConstants(10, 128);
}
TEST_METHOD(ModuloTest)
{
Rational rat25(25);
Rational ratminus25(-25);
Rational rat4(4);
Rational ratminus4(-4);
Rational res = Mod(rat25, rat4);
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"1");
res = Mod(rat25, ratminus4);
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"-3");
res = Mod(ratminus25, ratminus4);
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"-1");
res = Mod(ratminus25, rat4);
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"3");
res = Mod(Rational(426), Rational(56478));
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"426");
res = Mod(Rational(56478), Rational(426));
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"246");
res = Mod(Rational(-643), Rational(8756));
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"8113");
res = Mod(Rational(643), Rational(-8756));
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"-8113");
res = Mod(Rational(-643), Rational(-8756));
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"-643");
}
TEST_METHOD(RemainderTest)
{
Rational rat25(25);
Rational ratminus25(-25);
Rational rat4(4);
Rational ratminus4(-4);
Rational res = rat25 % rat4;
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"1");
res = rat25 % ratminus4;
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"1");
res = ratminus25 % ratminus4;
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"-1");
res = ratminus25 % rat4;
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"-1");
res = Rational(426) % Rational(56478);
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"426");
res = Rational(56478) % Rational(426);
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"246");
res = Rational(-643) % Rational(8756);
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"-643");
res = Rational(643) % Rational(-8756);
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"643");
res = Rational(-643) % Rational(-8756);
VERIFY_ARE_EQUAL(res.ToString(10, FMT_FLOAT, 128), L"-643");
}
};
}