github/msft-calculator
1
0
Fork 0
mirror of https://github.com/Microsoft/calculator.git synced 2025-08-22 06:13:14 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Simplify OnAppPropertyChanged

Browse source 
Use a switch statement instead of else-if
This commit is contained in:
Rose 2022-09-26 10:18:38 -04:00
commit 025518a6fc
1 changed files with 57 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

105
src/Calculator/Views/MainPage.xaml.cs
View file

@ -206,58 +206,67 @@ namespace CalculatorApp
KeyboardShortcutManager.DisableShortcuts(false); KeyboardShortcutManager.DisableShortcuts(false);
if (newValue == ViewMode.Standard) switch (newValue)
{ {
EnsureCalculator(); case ViewMode.Standard:
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = true; EnsureCalculator();
m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode)); Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = true;
Model.CalculatorViewModel.HistoryVM.ReloadHistory(newValue);
}
else if (newValue == ViewMode.Scientific)
{
EnsureCalculator();
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = true;
if (Model.PreviousMode != ViewMode.Scientific)
{
m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode)); m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode));
} Model.CalculatorViewModel.HistoryVM.ReloadHistory(newValue);
break;
case ViewMode.Scientific:
{
EnsureCalculator();
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = true;
if (Model.PreviousMode != ViewMode.Scientific)
{
m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode));
}
Model.CalculatorViewModel.HistoryVM.ReloadHistory(newValue); Model.CalculatorViewModel.HistoryVM.ReloadHistory(newValue);
} break;
else if (newValue == ViewMode.Programmer) }
{ case ViewMode.Programmer:
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false; {
EnsureCalculator(); Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false;
if (Model.PreviousMode != ViewMode.Programmer) EnsureCalculator();
{ if (Model.PreviousMode != ViewMode.Programmer)
m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode)); {
} m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode));
} }
else if (NavCategory.IsDateCalculatorViewMode(newValue))
{
if (Model.CalculatorViewModel != null)
{
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false;
}
EnsureDateCalculator();
}
else if (newValue == ViewMode.Graphing)
{
EnsureGraphingCalculator();
KeyboardShortcutManager.DisableShortcuts(true);
}
else if (NavCategory.IsConverterViewMode(newValue))
{
if (Model.CalculatorViewModel != null)
{
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false;
}
EnsureConverter(); break;
if (!NavCategory.IsConverterViewMode(previousMode)) }
{ case ViewMode.Graphing:
m_converter.AnimateConverter(); EnsureGraphingCalculator();
} KeyboardShortcutManager.DisableShortcuts(true);
break;
default:
{
if (NavCategory.IsDateCalculatorViewMode(newValue))
{
if (Model.CalculatorViewModel != null)
{
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false;
}
EnsureDateCalculator();
}
else if (NavCategory.IsConverterViewMode(newValue))
{
if (Model.CalculatorViewModel != null)
{
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false;
}
EnsureConverter();
if (!NavCategory.IsConverterViewMode(previousMode))
{
m_converter.AnimateConverter();
}
}
break;
}
} }
ShowHideControls(newValue); ShowHideControls(newValue);