From 71c51f3c873b447ba75c528c86b0f366ad777fa7 Mon Sep 17 00:00:00 2001 From: hay-kot Date: Sat, 1 May 2021 19:34:55 -0800 Subject: [PATCH] fix bare exception --- mealie/db/db_base.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mealie/db/db_base.py b/mealie/db/db_base.py index a89f642f2..b2c239ef8 100644 --- a/mealie/db/db_base.py +++ b/mealie/db/db_base.py @@ -1,11 +1,14 @@ from typing import List +from mealie.core.root_logger import get_logger from mealie.db.models.model_base import SqlAlchemyBase from pydantic import BaseModel from sqlalchemy import func from sqlalchemy.orm import load_only from sqlalchemy.orm.session import Session +logger = get_logger() + class BaseDocument: def __init__(self) -> None: @@ -145,11 +148,9 @@ class BaseDocument: def delete(self, session: Session, primary_key_value) -> dict: result = session.query(self.sql_model).filter_by(**{self.primary_key: primary_key_value}).one() + results_as_model = self.schema.from_orm(result) session.delete(result) session.commit() - try: - return self.schema.from_orm(result) - except Exception: - pass + return results_as_model