Fixed several issues in GrowlService:

Browse source

1) Calls to the growl SDK were not made in a thread safe manner

2) Loading the icon from a URL did not work in mono, and it made
   the GrowlService calls take exceptionally long

3) The result of the growl SDK calls was not checked

4) A bug in the growl for windows SDK caused the mono version
   on unix platforms to not work. A fixed version of the SDK is
   now included in the build (do not use the NuGet version, it's
   broken on unix). The bug was reported to growl for windows here:
   https://code.google.com/p/growl-for-windows/issues/detail?id=48

use var for locals

made requested changes from code review

Gave state class a better name

...

This commit is contained in:

Frank Riley 2014-08-07 22:18:22 -07:00

parent 75236118dd

commit e752e7f35d

8 changed files with 314 additions and 23 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

BIN

src/Libraries/Growl.Connector.dll Normal file

View file

Binary file not shown.

BIN

src/Libraries/Growl.CoreLibrary.dll Normal file

View file

Binary file not shown.