github/lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/lidarr.git synced 2025-07-14 00:53:57 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Prevent NullRef when deleting missing backups

Browse source 
(cherry picked from commit 0ff0fe2e68f3abf7b8e4d6bf0c1e9dee4eb68227)

Closes #3809
This commit is contained in:
Bogdan 2023-06-17 02:08:40 +03:00
parent 361eb2e53f
commit e6ceafa03b
1 changed files with 17 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/Lidarr.Api.V1/System/Backup/BackupController.cs
View file

@ -20,7 +20,7 @@ namespace Lidarr.Api.V1.System.Backup
private readonly IAppFolderInfo _appFolderInfo; private readonly IAppFolderInfo _appFolderInfo;
private readonly IDiskProvider _diskProvider; private readonly IDiskProvider _diskProvider;
private static readonly List<string> ValidExtensions = new List<string> { ".zip", ".db", ".xml" }; private static readonly List<string> ValidExtensions = new () { ".zip", ".db", ".xml" };
public BackupController(IBackupService backupService, public BackupController(IBackupService backupService,
IAppFolderInfo appFolderInfo, IAppFolderInfo appFolderInfo,
@ -37,22 +37,28 @@ namespace Lidarr.Api.V1.System.Backup
var backups = _backupService.GetBackups(); var backups = _backupService.GetBackups();
return backups.Select(b => new BackupResource return backups.Select(b => new BackupResource
{ {
Id = GetBackupId(b), Id = GetBackupId(b),
Name = b.Name, Name = b.Name,
Path = $"/backup/{b.Type.ToString().ToLower()}/{b.Name}", Path = $"/backup/{b.Type.ToString().ToLower()}/{b.Name}",
Type = b.Type, Type = b.Type,
Size = b.Size, Size = b.Size,
Time = b.Time Time = b.Time
}) })
.OrderByDescending(b => b.Time) .OrderByDescending(b => b.Time)
.ToList(); .ToList();
} }
[RestDeleteById] [RestDeleteById]
public void DeleteBackup(int id) public void DeleteBackup(int id)
{ {
var backup = GetBackup(id); var backup = GetBackup(id);
if (backup == null)
{
throw new NotFoundException();
}
var path = GetBackupPath(backup); var path = GetBackupPath(backup);
if (!_diskProvider.FileExists(path)) if (!_diskProvider.FileExists(path))