github/lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/lidarr.git synced 2025-08-19 13:10:13 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add minimum length as const in ApiKeyValidationCheck

Browse source 
(cherry picked from commit b06269544cfa11015f3fb938fd8c2ef07d9cac4a)

Closes #3755
This commit is contained in:
Bogdan 2023-05-13 15:23:01 +03:00
commit e5f9855640
2 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/NzbDrone.Core/HealthCheck/Checks/ApiKeyValidationCheck.cs
View file

@ -10,6 +10,8 @@ namespace NzbDrone.Core.HealthCheck.Checks
[CheckOn(typeof(ConfigSavedEvent))] [CheckOn(typeof(ConfigSavedEvent))]
public class ApiKeyValidationCheck : HealthCheckBase public class ApiKeyValidationCheck : HealthCheckBase
{ {
private const int MinimumLength = 20;
private readonly IConfigFileProvider _configFileProvider; private readonly IConfigFileProvider _configFileProvider;
private readonly Logger _logger; private readonly Logger _logger;
@ -22,11 +24,11 @@ namespace NzbDrone.Core.HealthCheck.Checks
public override HealthCheck Check() public override HealthCheck Check()
{ {
if (_configFileProvider.ApiKey.Length < 20) if (_configFileProvider.ApiKey.Length < MinimumLength)
{ {
_logger.Warn("Please update your API key to be at least 20 characters long. You can do this via settings or the config file"); _logger.Warn("Please update your API key to be at least {0} characters long. You can do this via settings or the config file", MinimumLength);
return new HealthCheck(GetType(), HealthCheckResult.Warning, _localizationService.GetLocalizedString("ApiKeyValidationHealthCheckMessage"), "#invalid-api-key"); return new HealthCheck(GetType(), HealthCheckResult.Warning, string.Format(_localizationService.GetLocalizedString("ApiKeyValidationHealthCheckMessage"), MinimumLength), "#invalid-api-key");
} }
return new HealthCheck(GetType()); return new HealthCheck(GetType());

2
src/NzbDrone.Core/Localization/Core/en.json
View file

@ -66,7 +66,7 @@
"AnchorTooltip": "This file is already in your library for a release you are currently importing", "AnchorTooltip": "This file is already in your library for a release you are currently importing",
"AnyReleaseOkHelpText": "Lidarr will automatically switch to the release best matching downloaded tracks", "AnyReleaseOkHelpText": "Lidarr will automatically switch to the release best matching downloaded tracks",
"ApiKeyHelpTextWarning": "Requires restart to take effect", "ApiKeyHelpTextWarning": "Requires restart to take effect",
"ApiKeyValidationHealthCheckMessage": "Please update your API key to be at least 20 characters long. You can do this via settings or the config file", "ApiKeyValidationHealthCheckMessage": "Please update your API key to be at least {0} characters long. You can do this via settings or the config file",
"AppDataDirectory": "AppData directory", "AppDataDirectory": "AppData directory",
"AppDataLocationHealthCheckMessage": "Updating will not be possible to prevent deleting AppData on Update", "AppDataLocationHealthCheckMessage": "Updating will not be possible to prevent deleting AppData on Update",
"ApplicationURL": "Application URL", "ApplicationURL": "Application URL",