mirror of
https://github.com/lidarr/lidarr.git
synced 2025-07-06 04:52:21 -07:00
Fixed: Convert MonoOnly to PosixOnly
This commit is contained in:
parent
8a938f6856
commit
d881b26261
14 changed files with 40 additions and 29 deletions
|
@ -38,7 +38,7 @@ namespace NzbDrone.Common.Test.DiskTests
|
||||||
[Test]
|
[Test]
|
||||||
public void should_use_verified_transfer_on_mono()
|
public void should_use_verified_transfer_on_mono()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
|
|
||||||
Subject.VerificationMode.Should().Be(DiskTransferVerificationMode.TryTransactional);
|
Subject.VerificationMode.Should().Be(DiskTransferVerificationMode.TryTransactional);
|
||||||
}
|
}
|
||||||
|
|
|
@ -19,7 +19,7 @@ namespace NzbDrone.Common.Test.EnsureTest
|
||||||
[TestCase(@"/var/user/file with, comma.mp3")]
|
[TestCase(@"/var/user/file with, comma.mp3")]
|
||||||
public void EnsureLinuxPath(string path)
|
public void EnsureLinuxPath(string path)
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
Ensure.That(path, () => path).IsValidPath();
|
Ensure.That(path, () => path).IsValidPath();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -53,7 +53,7 @@ namespace NzbDrone.Common.Test
|
||||||
[TestCase(@"//CAPITAL//lower// ", @"/CAPITAL/lower")]
|
[TestCase(@"//CAPITAL//lower// ", @"/CAPITAL/lower")]
|
||||||
public void Clean_Path_Linux(string dirty, string clean)
|
public void Clean_Path_Linux(string dirty, string clean)
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
|
|
||||||
var result = dirty.CleanFilePath();
|
var result = dirty.CleanFilePath();
|
||||||
result.Should().Be(clean);
|
result.Should().Be(clean);
|
||||||
|
@ -153,14 +153,14 @@ namespace NzbDrone.Common.Test
|
||||||
[TestCase(@"/test", "/")]
|
[TestCase(@"/test", "/")]
|
||||||
public void path_should_return_parent_mono(string path, string parentPath)
|
public void path_should_return_parent_mono(string path, string parentPath)
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
path.GetParentPath().Should().Be(parentPath);
|
path.GetParentPath().Should().Be(parentPath);
|
||||||
}
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
public void path_should_return_parent_for_oversized_path()
|
public void path_should_return_parent_for_oversized_path()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
|
|
||||||
// This test will fail on Windows if long path support is not enabled: https://www.howtogeek.com/266621/how-to-make-windows-10-accept-file-paths-over-260-characters/
|
// This test will fail on Windows if long path support is not enabled: https://www.howtogeek.com/266621/how-to-make-windows-10-accept-file-paths-over-260-characters/
|
||||||
// It will also fail if the app isn't configured to use long path (such as resharper): https://blogs.msdn.microsoft.com/jeremykuhne/2016/07/30/net-4-6-2-and-long-paths-on-windows-10/
|
// It will also fail if the app isn't configured to use long path (such as resharper): https://blogs.msdn.microsoft.com/jeremykuhne/2016/07/30/net-4-6-2-and-long-paths-on-windows-10/
|
||||||
|
@ -233,7 +233,7 @@ namespace NzbDrone.Common.Test
|
||||||
[Test]
|
[Test]
|
||||||
public void get_actual_casing_should_return_original_value_in_linux()
|
public void get_actual_casing_should_return_original_value_in_linux()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
var path = Directory.GetCurrentDirectory();
|
var path = Directory.GetCurrentDirectory();
|
||||||
path.GetActualCasing().Should().Be(path);
|
path.GetActualCasing().Should().Be(path);
|
||||||
path.GetActualCasing().Should().Be(path);
|
path.GetActualCasing().Should().Be(path);
|
||||||
|
@ -307,7 +307,7 @@ namespace NzbDrone.Common.Test
|
||||||
[Test]
|
[Test]
|
||||||
public void GetAncestorFolders_should_return_all_ancestors_in_path_Linux()
|
public void GetAncestorFolders_should_return_all_ancestors_in_path_Linux()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
var path = @"/Test/Music/Artist Title";
|
var path = @"/Test/Music/Artist Title";
|
||||||
var result = path.GetAncestorFolders();
|
var result = path.GetAncestorFolders();
|
||||||
|
|
||||||
|
|
|
@ -142,6 +142,7 @@ namespace NzbDrone.Common.EnvironmentInfo
|
||||||
{
|
{
|
||||||
var currentAssemblyLocation = typeof(RuntimeInfo).Assembly.Location;
|
var currentAssemblyLocation = typeof(RuntimeInfo).Assembly.Location;
|
||||||
if (currentAssemblyLocation.ToLower().Contains("_output")) return true;
|
if (currentAssemblyLocation.ToLower().Contains("_output")) return true;
|
||||||
|
if (currentAssemblyLocation.ToLower().Contains("_tests")) return true;
|
||||||
}
|
}
|
||||||
catch
|
catch
|
||||||
{
|
{
|
||||||
|
@ -152,6 +153,7 @@ namespace NzbDrone.Common.EnvironmentInfo
|
||||||
if (lowerCurrentDir.Contains("vsts")) return true;
|
if (lowerCurrentDir.Contains("vsts")) return true;
|
||||||
if (lowerCurrentDir.Contains("buildagent")) return true;
|
if (lowerCurrentDir.Contains("buildagent")) return true;
|
||||||
if (lowerCurrentDir.Contains("_output")) return true;
|
if (lowerCurrentDir.Contains("_output")) return true;
|
||||||
|
if (lowerCurrentDir.Contains("_tests")) return true;
|
||||||
|
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
|
@ -443,7 +443,7 @@ namespace NzbDrone.Core.Test.Download
|
||||||
[Test]
|
[Test]
|
||||||
public void should_warn_if_path_is_not_valid_for_linux()
|
public void should_warn_if_path_is_not_valid_for_linux()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
|
|
||||||
_trackedDownload.DownloadItem.OutputPath = new OsPath(@"C:\Invalid\Mono\Path");
|
_trackedDownload.DownloadItem.OutputPath = new OsPath(@"C:\Invalid\Mono\Path");
|
||||||
|
|
||||||
|
|
|
@ -1,4 +1,5 @@
|
||||||
using NUnit.Framework;
|
using NUnit.Framework;
|
||||||
|
using NzbDrone.Common.EnvironmentInfo;
|
||||||
using NzbDrone.Core.HealthCheck.Checks;
|
using NzbDrone.Core.HealthCheck.Checks;
|
||||||
using NzbDrone.Core.Test.Framework;
|
using NzbDrone.Core.Test.Framework;
|
||||||
using NzbDrone.Test.Common;
|
using NzbDrone.Test.Common;
|
||||||
|
@ -17,9 +18,12 @@ namespace NzbDrone.Core.Test.HealthCheck.Checks
|
||||||
}
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
public void should_return_ok_if_windows()
|
public void should_return_ok_if_not_mono()
|
||||||
{
|
{
|
||||||
WindowsOnly();
|
if (PlatformInfo.IsMono)
|
||||||
|
{
|
||||||
|
throw new IgnoreException("non mono specific test");
|
||||||
|
}
|
||||||
|
|
||||||
Subject.Check().ShouldBeOk();
|
Subject.Check().ShouldBeOk();
|
||||||
}
|
}
|
||||||
|
|
|
@ -31,7 +31,7 @@ namespace NzbDrone.Core.Test.HealthCheck.Checks
|
||||||
[Test]
|
[Test]
|
||||||
public void should_return_error_when_app_folder_is_write_protected_and_update_automatically_is_enabled()
|
public void should_return_error_when_app_folder_is_write_protected_and_update_automatically_is_enabled()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
|
|
||||||
const string startupFolder = @"/opt/nzbdrone";
|
const string startupFolder = @"/opt/nzbdrone";
|
||||||
|
|
||||||
|
@ -53,7 +53,7 @@ namespace NzbDrone.Core.Test.HealthCheck.Checks
|
||||||
[Test]
|
[Test]
|
||||||
public void should_return_error_when_ui_folder_is_write_protected_and_update_automatically_is_enabled()
|
public void should_return_error_when_ui_folder_is_write_protected_and_update_automatically_is_enabled()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
|
|
||||||
const string startupFolder = @"/opt/nzbdrone";
|
const string startupFolder = @"/opt/nzbdrone";
|
||||||
const string uiFolder = @"/opt/nzbdrone/UI";
|
const string uiFolder = @"/opt/nzbdrone/UI";
|
||||||
|
@ -80,7 +80,7 @@ namespace NzbDrone.Core.Test.HealthCheck.Checks
|
||||||
[Test]
|
[Test]
|
||||||
public void should_not_return_error_when_app_folder_is_write_protected_and_external_script_enabled()
|
public void should_not_return_error_when_app_folder_is_write_protected_and_external_script_enabled()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
|
|
||||||
Mocker.GetMock<IConfigFileProvider>()
|
Mocker.GetMock<IConfigFileProvider>()
|
||||||
.Setup(s => s.UpdateAutomatically)
|
.Setup(s => s.UpdateAutomatically)
|
||||||
|
|
|
@ -137,7 +137,7 @@ namespace NzbDrone.Core.Test.MediaFiles.MediaFileServiceTests
|
||||||
[TestCase(FilterFilesType.Matched)]
|
[TestCase(FilterFilesType.Matched)]
|
||||||
public void filter_should_return_none_existing_files_not_ignoring_case(FilterFilesType filter)
|
public void filter_should_return_none_existing_files_not_ignoring_case(FilterFilesType filter)
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
|
|
||||||
var files = GivenFiles(new []
|
var files = GivenFiles(new []
|
||||||
{
|
{
|
||||||
|
|
|
@ -74,7 +74,7 @@ namespace NzbDrone.Core.Test.MediaFiles.TrackImport.Specifications
|
||||||
[Test]
|
[Test]
|
||||||
public void should_return_false_if_unopacking_on_linux()
|
public void should_return_false_if_unopacking_on_linux()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
|
|
||||||
GivenInWorkingFolder();
|
GivenInWorkingFolder();
|
||||||
GivenLastWriteTimeUtc(DateTime.UtcNow.AddDays(-5));
|
GivenLastWriteTimeUtc(DateTime.UtcNow.AddDays(-5));
|
||||||
|
|
|
@ -181,7 +181,7 @@ namespace NzbDrone.Core.Test.UpdateTests
|
||||||
}
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
[Platform("Mono")]
|
[Platform(Exclude="Win")]
|
||||||
public void should_run_script_if_configured()
|
public void should_run_script_if_configured()
|
||||||
{
|
{
|
||||||
const string scriptPath = "/tmp/lidarr/update.sh";
|
const string scriptPath = "/tmp/lidarr/update.sh";
|
||||||
|
@ -194,7 +194,7 @@ namespace NzbDrone.Core.Test.UpdateTests
|
||||||
}
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
[Platform("Mono")]
|
[Platform(Exclude="Win")]
|
||||||
public void should_throw_if_script_is_not_set()
|
public void should_throw_if_script_is_not_set()
|
||||||
{
|
{
|
||||||
const string scriptPath = "/tmp/lidarr/update.sh";
|
const string scriptPath = "/tmp/lidarr/update.sh";
|
||||||
|
@ -208,7 +208,7 @@ namespace NzbDrone.Core.Test.UpdateTests
|
||||||
}
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
[Platform("Mono")]
|
[Platform(Exclude="Win")]
|
||||||
public void should_throw_if_script_is_null()
|
public void should_throw_if_script_is_null()
|
||||||
{
|
{
|
||||||
const string scriptPath = "/tmp/lidarr/update.sh";
|
const string scriptPath = "/tmp/lidarr/update.sh";
|
||||||
|
@ -222,7 +222,7 @@ namespace NzbDrone.Core.Test.UpdateTests
|
||||||
}
|
}
|
||||||
|
|
||||||
[Test]
|
[Test]
|
||||||
[Platform("Mono")]
|
[Platform(Exclude="Win")]
|
||||||
public void should_throw_if_script_path_does_not_exist()
|
public void should_throw_if_script_path_does_not_exist()
|
||||||
{
|
{
|
||||||
const string scriptPath = "/tmp/lidarr/update.sh";
|
const string scriptPath = "/tmp/lidarr/update.sh";
|
||||||
|
|
|
@ -51,7 +51,7 @@ namespace NzbDrone.Core.Test.ValidationTests
|
||||||
[Test]
|
[Test]
|
||||||
public void should_not_be_valid_if_set_to_bin_folder()
|
public void should_not_be_valid_if_set_to_bin_folder()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
|
|
||||||
var bin = OsInfo.IsOsx ? "/System" : "/bin";
|
var bin = OsInfo.IsOsx ? "/System" : "/bin";
|
||||||
var artist = Builder<Artist>.CreateNew()
|
var artist = Builder<Artist>.CreateNew()
|
||||||
|
@ -64,7 +64,7 @@ namespace NzbDrone.Core.Test.ValidationTests
|
||||||
[Test]
|
[Test]
|
||||||
public void should_not_be_valid_if_child_of_bin_folder()
|
public void should_not_be_valid_if_child_of_bin_folder()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
|
|
||||||
var bin = OsInfo.IsOsx ? "/System" : "/bin";
|
var bin = OsInfo.IsOsx ? "/System" : "/bin";
|
||||||
var artist = Builder<Artist>.CreateNew()
|
var artist = Builder<Artist>.CreateNew()
|
||||||
|
|
|
@ -14,12 +14,12 @@ using NzbDrone.Mono.Disk;
|
||||||
namespace NzbDrone.Mono.Test.DiskProviderTests
|
namespace NzbDrone.Mono.Test.DiskProviderTests
|
||||||
{
|
{
|
||||||
[TestFixture]
|
[TestFixture]
|
||||||
[Platform("Mono")]
|
[Platform(Exclude="Win")]
|
||||||
public class DiskProviderFixture : DiskProviderFixtureBase<DiskProvider>
|
public class DiskProviderFixture : DiskProviderFixtureBase<DiskProvider>
|
||||||
{
|
{
|
||||||
public DiskProviderFixture()
|
public DiskProviderFixture()
|
||||||
{
|
{
|
||||||
MonoOnly();
|
PosixOnly();
|
||||||
}
|
}
|
||||||
|
|
||||||
protected override void SetWritePermissions(string path, bool writable)
|
protected override void SetWritePermissions(string path, bool writable)
|
||||||
|
|
|
@ -1,16 +1,13 @@
|
||||||
using System.Collections.Generic;
|
|
||||||
using System.IO;
|
|
||||||
using FluentAssertions;
|
|
||||||
using Moq;
|
using Moq;
|
||||||
using NUnit.Framework;
|
|
||||||
using NzbDrone.Common.Disk;
|
|
||||||
using NzbDrone.Common.Test.DiskTests;
|
using NzbDrone.Common.Test.DiskTests;
|
||||||
using NzbDrone.Mono.Disk;
|
using NzbDrone.Mono.Disk;
|
||||||
|
using NUnit.Framework;
|
||||||
|
using FluentAssertions;
|
||||||
|
|
||||||
namespace NzbDrone.Mono.Test.DiskProviderTests
|
namespace NzbDrone.Mono.Test.DiskProviderTests
|
||||||
{
|
{
|
||||||
[TestFixture]
|
[TestFixture]
|
||||||
[Platform("Mono")]
|
[Platform(Exclude="Win")]
|
||||||
public class FreeSpaceFixture : FreeSpaceFixtureBase<DiskProvider>
|
public class FreeSpaceFixture : FreeSpaceFixtureBase<DiskProvider>
|
||||||
{
|
{
|
||||||
public FreeSpaceFixture()
|
public FreeSpaceFixture()
|
||||||
|
|
|
@ -160,6 +160,14 @@ namespace NzbDrone.Test.Common
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
protected void PosixOnly()
|
||||||
|
{
|
||||||
|
if (OsInfo.IsWindows)
|
||||||
|
{
|
||||||
|
throw new IgnoreException("non windows specific test");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
protected void MonoOnly()
|
protected void MonoOnly()
|
||||||
{
|
{
|
||||||
if (!PlatformInfo.IsMono)
|
if (!PlatformInfo.IsMono)
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue