github/lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/lidarr.git synced 2025-07-30 11:48:26 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Always validate Custom Script path

Browse source 
(cherry picked from commit c922cc5dc617dd776d4523cbf62376821c5a4ad9)
This commit is contained in:
Mark McDowall 2023-11-19 00:17:32 -08:00 • committed by Bogdan
parent c51351a09b
commit bdf5ad2e2b
2 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/NzbDrone.Core/Notifications/CustomScript/CustomScript.cs
View file

@ -285,14 +285,6 @@ namespace NzbDrone.Core.Notifications.CustomScript
failures.Add(new NzbDroneValidationFailure("Path", "File does not exist")); failures.Add(new NzbDroneValidationFailure("Path", "File does not exist"));
} }
foreach (var systemFolder in SystemFolders.GetSystemFolders())
{
if (systemFolder.IsParentPath(Settings.Path))
{
failures.Add(new NzbDroneValidationFailure("Path", $"Must not be a descendant of '{systemFolder}'"));
}
}
if (failures.Empty()) if (failures.Empty())
{ {
try try

1
src/NzbDrone.Core/Notifications/CustomScript/CustomScriptSettings.cs
View file

@ -11,6 +11,7 @@ namespace NzbDrone.Core.Notifications.CustomScript
public CustomScriptSettingsValidator() public CustomScriptSettingsValidator()
{ {
RuleFor(c => c.Path).IsValidPath(); RuleFor(c => c.Path).IsValidPath();
RuleFor(c => c.Path).SetValidator(new SystemFolderValidator()).WithMessage("Must not be a descendant of '{systemFolder}'");
RuleFor(c => c.Arguments).Empty().WithMessage("Arguments are no longer supported for custom scripts"); RuleFor(c => c.Arguments).Empty().WithMessage("Arguments are no longer supported for custom scripts");
} }
} }