Whole album matching and fingerprinting (#592)

* Cache result of GetAllArtists

* Fixed: Manual import not respecting album import notifications

* Fixed: partial album imports stay in queue, prompting manual import

* Fixed: Allow release if tracks are missing

* Fixed: Be tolerant of missing/extra "The" at start of artist name

* Improve manual import UI

* Omit video tracks from DB entirely

* Revert "faster test packaging in build.sh"

This reverts commit 2723e2a7b8.

-u and -T are not supported on macOS

* Fix tests on linux and macOS

* Actually lint on linux

On linux yarn runs scripts with sh not bash so ** doesn't recursively glob

* Match whole albums

* Option to disable fingerprinting

* Rip out MediaInfo

* Don't split up things that have the same album selected in manual import

* Try to speed up IndentificationService

* More speedups

* Some fixes and increase power of recording id

* Fix NRE when no tags

* Fix NRE when some (but not all) files in a directory have missing tags

* Bump taglib, tidy up tag parsing

* Add a health check

* Remove media info setting

* Tags -> audioTags

* Add some tests where tags are null

* Rename history events

* Add missing method to interface

* Reinstate MediaInfo tags and update info with artist scan

Also adds migration to remove old format media info

* This file no longer exists

* Don't penalise year if missing from tags

* Formatting improvements

* Use correct system newline

* Switch to the netstandard2.0 library to support net 461

* TagLib.File is IDisposable so should be in a using

* Improve filename matching and add tests

* Neater logging of parsed tags

* Fix disk scan tests for new media info update

* Fix quality detection source

* Fix Inexact Artist/Album match

* Add button to clear track mapping

* Fix warning

* Pacify eslint

* Use \ not /

* Fix UI updates

* Fix media covers

Prevent localizing URL propaging back to the metadata object

* Reduce database overhead broadcasting UI updates

* Relax timings a bit to make test pass

* Remove irrelevant tests

* Test framework for identification service

* Fix PreferMissingToBadMatch test case

* Make fingerprinting more robust

* More logging

* Penalize unknown media format and country

* Prefer USA to UK

* Allow Data CD

* Fix exception if fingerprinting fails for all files

* Fix tests

* Fix NRE

* Allow apostrophes and remove accents in filename aggregation

* Address codacy issues

* Cope with old versions of fpcalc and suggest upgrade

* fpcalc health check passes if fingerprinting disabled

* Get the Artist meta with the artist

* Fix the mapper so that lazy loaded lists will be populated on Join

And therefore we can join TrackFiles on Tracks by default and avoid an
extra query

* Rename subtitle -> lyric

* Tidy up MediaInfoFormatter

src/Lidarr.Api.V1/TrackFiles/TrackFileModule.cs

@@ -53,9 +53,8 @@ namespace Lidarr.Api.V1.TrackFiles
         private TrackFileResource GetTrackFile(int id)
         {
             var trackFile = _mediaFileService.Get(id);
-            var artist = _artistService.GetArtist(trackFile.ArtistId);
 
-            return trackFile.ToResource(artist, _upgradableSpecification);
+            return trackFile.ToResource(trackFile.Artist.Value, _upgradableSpecification);
         }
 
         private List<TrackFileResource> GetTrackFiles()
@@ -94,12 +93,9 @@ namespace Lidarr.Api.V1.TrackFiles
                                                         .Select(e => Convert.ToInt32(e))
                                                         .ToList();
 
+                // trackfiles will come back with the artist already populated
                 var trackFiles = _mediaFileService.Get(trackFileIds);
-
-                return trackFiles.GroupBy(e => e.ArtistId)
-                                   .SelectMany(f => f.ToList()
-                                                     .ConvertAll(e => e.ToResource(_artistService.GetArtist(f.Key), _upgradableSpecification)))
-                                   .ToList();
+                return trackFiles.ConvertAll(e => e.ToResource(e.Artist.Value, _upgradableSpecification));
             }
         }
 
@@ -113,7 +109,7 @@ namespace Lidarr.Api.V1.TrackFiles
         private Response SetQuality()
         {
             var resource = Request.Body.FromJson<TrackFileListResource>();
-            var trackFiles = _mediaFileService.GetFiles(resource.TrackFileIds);
+            var trackFiles = _mediaFileService.Get(resource.TrackFileIds);
 
             foreach (var trackFile in trackFiles)
             {
@@ -130,9 +126,7 @@ namespace Lidarr.Api.V1.TrackFiles
 
             _mediaFileService.Update(trackFiles);
 
-            var artist = _artistService.GetArtist(trackFiles.First().ArtistId);
-
-            return trackFiles.ConvertAll(f => f.ToResource(artist, _upgradableSpecification))
+            return trackFiles.ConvertAll(f => f.ToResource(trackFiles.First().Artist.Value, _upgradableSpecification))
                                .AsResponse(Nancy.HttpStatusCode.Accepted);
         }
 
@@ -145,7 +139,7 @@ namespace Lidarr.Api.V1.TrackFiles
                 throw new NzbDroneClientException(HttpStatusCode.NotFound, "Track file not found");
             }
 
-            var artist = _artistService.GetArtist(trackFile.ArtistId);
+            var artist = trackFile.Artist.Value;
             var fullPath = Path.Combine(artist.Path, trackFile.RelativePath);
 
             _mediaFileDeletionService.DeleteTrackFile(artist, trackFile);
@@ -154,8 +148,8 @@ namespace Lidarr.Api.V1.TrackFiles
         private Response DeleteTrackFiles()
         {
             var resource = Request.Body.FromJson<TrackFileListResource>();
-            var trackFiles = _mediaFileService.GetFiles(resource.TrackFileIds);
-            var artist = _artistService.GetArtist(trackFiles.First().ArtistId);
+            var trackFiles = _mediaFileService.Get(resource.TrackFileIds);
+            var artist = trackFiles.First().Artist.Value;
 
             foreach (var trackFile in trackFiles)
             {
@@ -169,12 +163,12 @@ namespace Lidarr.Api.V1.TrackFiles
 
         public void Handle(TrackFileAddedEvent message)
         {
-            BroadcastResourceChange(ModelAction.Updated, message.TrackFile.Id);
+            BroadcastResourceChange(ModelAction.Updated, message.TrackFile.ToResource(message.TrackFile.Artist.Value, _upgradableSpecification));
         }
 
         public void Handle(TrackFileDeletedEvent message)
         {
-            BroadcastResourceChange(ModelAction.Deleted, message.TrackFile.Id);
+            BroadcastResourceChange(ModelAction.Deleted, message.TrackFile.ToResource(message.TrackFile.Artist.Value, _upgradableSpecification));
         }
 
     }