github/lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/lidarr.git synced 2025-07-05 20:42:19 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Optimize querying for missing albums

Browse source 
| Problem                  | Cause                                                      |
|--------------------------|------------------------------------------------------------|
| High row count           | selecting rows before grouping and sorting                 |
| Large sort in memory     | GB of memory used for low millions of records w/ quicksort |
| Expensive Anti Join      | On `TrackFiles.Id IS NULL` condition                       |
| Grouping before LIMIT    | Entire result grouped before applying LIMIT+OFFSET         |
This commit is contained in:
Jack Danger 2025-04-06 12:25:44 -07:00
parent 4677a1115a
commit 92cf3546e6
1 changed files with 16 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/NzbDrone.Core/Music/Repositories/AlbumRepository.cs
View file

@ -90,22 +90,26 @@ namespace NzbDrone.Core.Music
return Query(s => s.ForeignAlbumId == foreignAlbumId).SingleOrDefault();
}
// x.Id == null is converted to SQL, so warning incorrect
#pragma warning disable CS0472
private SqlBuilder AlbumsWithoutFilesBuilder(DateTime currentTime)
{
return Builder()
.Join<Album, Artist>((l, r) => l.ArtistMetadataId == r.ArtistMetadataId)
.Join<Album, AlbumRelease>((a, r) => a.Id == r.AlbumId)
// First, create a subquery to find albums with missing tracks
var missingTracksSubquery = Builder()
.Select("\"AlbumReleases\".\"AlbumId\"")
.Join<AlbumRelease, Track>((r, t) => r.Id == t.AlbumReleaseId)
.LeftJoin<Track, TrackFile>((t, f) => t.TrackFileId == f.Id)
.Where<TrackFile>(f => f.Id == null)
.Where<TrackFile>(f => f == null)
.Where<AlbumRelease>(r => r.Monitored == true)
.Where<Album>(a => a.ReleaseDate <= currentTime)
.GroupBy("\"AlbumReleases\".\"AlbumId\"");
// Main query that joins with the subquery
return Builder()
.Join<Album, Artist>((l, r) => l.ArtistMetadataId == r.ArtistMetadataId)
.Where<Album>(a => a.Monitored == true && a.ReleaseDate <= currentTime)
.Where<Artist>(a => a.Monitored == true)
.Where("\"Albums\".\"Id\" IN (SELECT \"AlbumReleases\".\"AlbumId\" FROM \"AlbumReleases\" JOIN \"Tracks\" ON (\"AlbumReleases\".\"Id\" = \"Tracks\".\"AlbumReleaseId\") LEFT JOIN \"TrackFiles\" ON (\"Tracks\".\"TrackFileId\" = \"TrackFiles\".\"Id\") WHERE \"TrackFiles\" IS NULL AND \"AlbumReleases\".\"Monitored\" = true GROUP BY \"AlbumReleases\".\"AlbumId\")")
.GroupBy<Album>(x => x.Id)
.GroupBy<Artist>(x => x.SortName);
}
#pragma warning restore CS0472
public PagingSpec<Album> AlbumsWithoutFiles(PagingSpec<Album> pagingSpec)
{