github/lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/lidarr.git synced 2025-08-14 10:47:08 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fixed: Catch exceptions looking up fingerprints

Browse source 
It's not crucial so if it fails don't take out the whole import process.
This commit is contained in:
ta264 2019-08-28 21:14:09 +01:00
commit 91ddabe5dd
2 changed files with 19 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/NzbDrone.Core.Test/ParserTests/FingerprintingServiceFixture.cs
View file

@ -200,5 +200,19 @@ FINGERPRINT=AQAHJlMURlEURcgP6cwRD43Y4Ptw9FowncWPWkf6GB9-JYdP9OgJHw8u4Apw4SsOHMdx
ExceptionVerification.ExpectedWarns(1);
}
[Test]
public void should_not_throw_if_api_times_out()
{
Mocker.GetMock<IHttpClient>().Setup(x => x.Post<LookupResponse>(It.IsAny<HttpRequest>()))
.Throws(new System.Net.WebException("The operation has timed out."));
var path = Path.Combine(TestContext.CurrentContext.TestDirectory, "Files", "Media", "nin.mp3");
var localTrack = new LocalTrack { Path = path };
Subject.Lookup(new List<LocalTrack> { localTrack }, 0.5);
localTrack.AcoustIdResults.Should().BeNull();
ExceptionVerification.ExpectedWarns(1);
}
}
}

5
src/NzbDrone.Core/Parser/FingerprintingService.cs
View file

@ -375,6 +375,11 @@ namespace NzbDrone.Core.Parser
_logger.Warn(e, "AcoustId API gave invalid response");
return;
}
catch (Exception e)
{
_logger.Warn(e, "AcoustId API lookup failed");
return;
}
var response = httpResponse.Resource;