github/lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/lidarr.git synced 2025-07-16 10:03:51 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fixed: Simplify ArtistMetadataRepository

Browse source
This commit is contained in:
ta264 2019-07-17 12:59:34 +01:00
parent 0b7a42ee3b
commit 8160f3d84a
3 changed files with 5 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/NzbDrone.Core.Test/MusicTests/ArtistRepositoryTests/ArtistRepositoryFixture.cs
View file

@ -46,7 +46,8 @@ namespace NzbDrone.Core.Test.MusicTests.ArtistRepositoryTests
.BuildNew(); .BuildNew();
_id++; _id++;
_artistMetadataRepo.Insert(artist); _artistMetadataRepo.Insert(metadata);
artist.ArtistMetadataId = metadata.Id;
_artistRepo.Insert(artist); _artistRepo.Insert(artist);
} }

8
src/NzbDrone.Core/Music/AddArtistService.cs
View file

@ -87,11 +87,9 @@ namespace NzbDrone.Core.Music
} }
// add metadata // add metadata
_artistMetadataRepository.UpsertMany(artistsToAdd); _artistMetadataRepository.UpsertMany(artistsToAdd.Select(x => x.Metadata.Value).ToList());
artistsToAdd.ForEach(x => x.ArtistMetadataId = x.Metadata.Value.Id);
_logger.Debug("metadata id 1 {0}", string.Join(", ", artistsToAdd.Select(x => x.Metadata.Value.Id)));
_logger.Debug("metadata id 2 {0}", string.Join(", ", artistsToAdd.Select(x => x.ArtistMetadataId)));
return _artistService.AddArtists(artistsToAdd); return _artistService.AddArtists(artistsToAdd);
} }

63
src/NzbDrone.Core/Music/ArtistMetadataRepository.cs
View file

@ -8,15 +8,8 @@ namespace NzbDrone.Core.Music
{ {
public interface IArtistMetadataRepository : IBasicRepository<ArtistMetadata> public interface IArtistMetadataRepository : IBasicRepository<ArtistMetadata>
{ {
Artist Insert(Artist artist);
List<Artist> InsertMany(List<Artist> artists);
Artist Update(Artist artist);
Artist Upsert(Artist artist);
void UpdateMany(List<Artist> artists);
ArtistMetadata FindById(string foreignArtistId);
List<ArtistMetadata> FindById(List<string> foreignIds); List<ArtistMetadata> FindById(List<string> foreignIds);
bool UpsertMany(List<ArtistMetadata> artists); bool UpsertMany(List<ArtistMetadata> artists);
bool UpsertMany(List<Artist> artists);
} }
public class ArtistMetadataRepository : BasicRepository<ArtistMetadata>, IArtistMetadataRepository public class ArtistMetadataRepository : BasicRepository<ArtistMetadata>, IArtistMetadataRepository
@ -29,62 +22,6 @@ namespace NzbDrone.Core.Music
_logger = logger; _logger = logger;
} }
public Artist Insert(Artist artist)
{
Insert(artist.Metadata.Value);
artist.ArtistMetadataId = artist.Metadata.Value.Id;
return artist;
}
public List<Artist> InsertMany(List<Artist> artists)
{
InsertMany(artists.Select(x => x.Metadata.Value).ToList());
artists.ForEach(x => x.ArtistMetadataId = x.Metadata.Value.Id);
return artists;
}
public Artist Update(Artist artist)
{
Update(artist.Metadata.Value);
return artist;
}
public Artist Upsert(Artist artist)
{
var existing = FindById(artist.Metadata.Value.ForeignArtistId);
if (existing != null)
{
artist.ArtistMetadataId = existing.Id;
artist.Metadata.Value.Id = existing.Id;
Update(artist);
}
else
{
Insert(artist);
}
_logger.Debug("Upserted metadata with ID {0}", artist.Id);
return artist;
}
public bool UpsertMany(List<Artist> artists)
{
var result = UpsertMany(artists.Select(x => x.Metadata.Value).ToList());
artists.ForEach(x => x.ArtistMetadataId = x.Metadata.Value.Id);
return result;
}
public void UpdateMany(List<Artist> artists)
{
UpdateMany(artists.Select(x => x.Metadata.Value).ToList());
}
public ArtistMetadata FindById(string foreignArtistId)
{
return Query.Where(a => a.ForeignArtistId == foreignArtistId).SingleOrDefault();
}
public List<ArtistMetadata> FindById(List<string> foreignIds) public List<ArtistMetadata> FindById(List<string> foreignIds)
{ {
return Query.Where($"[ForeignArtistId] IN ('{string.Join("','", foreignIds)}')").ToList(); return Query.Where($"[ForeignArtistId] IN ('{string.Join("','", foreignIds)}')").ToList();