github/lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/lidarr.git synced 2025-07-16 10:03:51 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fixed: Enforce validation warnings

Browse source 
(cherry picked from commit 48ee1158ad4213fd0690842e2672f52d08f7ad26)

Closes #3761
This commit is contained in:
Bogdan 2023-05-26 18:35:31 +03:00
parent a05082b4c6
commit 59b4441b0d
3 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
frontend/src/Store/Actions/Creators/createSaveProviderHandler.js
View file

@ -32,9 +32,9 @@ function createSaveProviderHandler(section, url, options = {}, removeStale = fal
const params = { ...queryParams }; const params = { ...queryParams };
// If the user is re-saving the same provider without changes // If the user is re-saving the same provider without changes
// force it to be saved. Only applies to editing existing providers. // force it to be saved.
if (id && _.isEqual(saveData, lastSaveData)) { if (_.isEqual(saveData, lastSaveData)) {
params.forceSave = true; params.forceSave = true;
} }

8
src/Lidarr.Api.V1/ProviderControllerBase.cs
View file

@ -58,9 +58,9 @@ namespace Lidarr.Api.V1
} }
[RestPostById] [RestPostById]
public ActionResult<TProviderResource> CreateProvider(TProviderResource providerResource) public ActionResult<TProviderResource> CreateProvider([FromBody] TProviderResource providerResource, [FromQuery] bool forceSave = false)
{ {
var providerDefinition = GetDefinition(providerResource, true, false, false); var providerDefinition = GetDefinition(providerResource, true, !forceSave, false);
if (providerDefinition.Enable) if (providerDefinition.Enable)
{ {
@ -75,7 +75,7 @@ namespace Lidarr.Api.V1
[RestPutById] [RestPutById]
public ActionResult<TProviderResource> UpdateProvider([FromBody] TProviderResource providerResource, [FromQuery] bool forceSave = false) public ActionResult<TProviderResource> UpdateProvider([FromBody] TProviderResource providerResource, [FromQuery] bool forceSave = false)
{ {
var providerDefinition = GetDefinition(providerResource, true, false, false); var providerDefinition = GetDefinition(providerResource, true, !forceSave, false);
// Only test existing definitions if it is enabled and forceSave isn't set. // Only test existing definitions if it is enabled and forceSave isn't set.
if (providerDefinition.Enable && !forceSave) if (providerDefinition.Enable && !forceSave)
@ -191,7 +191,7 @@ namespace Lidarr.Api.V1
protected void VerifyValidationResult(ValidationResult validationResult, bool includeWarnings) protected void VerifyValidationResult(ValidationResult validationResult, bool includeWarnings)
{ {
var result = new NzbDroneValidationResult(validationResult.Errors); var result = validationResult as NzbDroneValidationResult ?? new NzbDroneValidationResult(validationResult.Errors);
if (includeWarnings && (!result.IsValid || result.HasWarnings)) if (includeWarnings && (!result.IsValid || result.HasWarnings))
{ {

2
src/NzbDrone.Core/Indexers/SeedCriteriaSettings.cs
View file

@ -48,8 +48,6 @@ namespace NzbDrone.Core.Indexers
public class SeedCriteriaSettings public class SeedCriteriaSettings
{ {
private static readonly SeedCriteriaSettingsValidator Validator = new SeedCriteriaSettingsValidator();
[FieldDefinition(0, Type = FieldType.Textbox, Label = "Seed Ratio", HelpText = "The ratio a torrent should reach before stopping, empty is download client's default. Ratio should be at least 1.0 and follow the indexers rules")] [FieldDefinition(0, Type = FieldType.Textbox, Label = "Seed Ratio", HelpText = "The ratio a torrent should reach before stopping, empty is download client's default. Ratio should be at least 1.0 and follow the indexers rules")]
public double? SeedRatio { get; set; } public double? SeedRatio { get; set; }