From 541841d7b7595c7acc09dafff7ad2fb453d84bcb Mon Sep 17 00:00:00 2001 From: ta264 Date: Wed, 1 May 2019 06:42:01 +0100 Subject: [PATCH] Don't try to match a null codec name (#784) * Don't try to match a null codec name * Add test --- src/NzbDrone.Core.Test/ParserTests/QualityParserFixture.cs | 6 ++++++ src/NzbDrone.Core/Parser/QualityParser.cs | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/src/NzbDrone.Core.Test/ParserTests/QualityParserFixture.cs b/src/NzbDrone.Core.Test/ParserTests/QualityParserFixture.cs index 33de373d5..f09a846d3 100644 --- a/src/NzbDrone.Core.Test/ParserTests/QualityParserFixture.cs +++ b/src/NzbDrone.Core.Test/ParserTests/QualityParserFixture.cs @@ -284,6 +284,12 @@ namespace NzbDrone.Core.Test.ParserTests QualityParser.ParseQuality(title, null, 0).QualityDetectionSource.Should().Be(QualityDetectionSource.Extension); } + [Test] + public void should_parse_null_quality_description_as_unknown() + { + QualityParser.ParseCodec(null, null).Should().Be(Codec.Unknown); + } + private void ParseAndVerifyQuality(string name, string desc, int bitrate, Quality quality, int sampleSize = 0) { var result = QualityParser.ParseQuality(name, desc, bitrate, sampleSize); diff --git a/src/NzbDrone.Core/Parser/QualityParser.cs b/src/NzbDrone.Core/Parser/QualityParser.cs index 56a151084..b8ecc96e7 100644 --- a/src/NzbDrone.Core/Parser/QualityParser.cs +++ b/src/NzbDrone.Core/Parser/QualityParser.cs @@ -154,6 +154,11 @@ namespace NzbDrone.Core.Parser public static Codec ParseCodec(string name, string origName) { + if (name.IsNullOrWhiteSpace()) + { + return Codec.Unknown; + } + var match = CodecRegex.Match(name); if (!match.Success) { return Codec.Unknown; }