Fixes from code review

This commit is contained in:
ManiMatter 2024-10-02 20:50:09 +02:00
parent 2f149ade30
commit 53be155e9d
2 changed files with 24 additions and 19 deletions

7
.gitignore vendored
View file

@ -132,7 +132,6 @@ setup/Output/
bin bin
obj obj
output/* output/*
_temp*
# .NET Core # .NET Core
project.lock.json project.lock.json
@ -140,6 +139,12 @@ project.fragment.lock.json
artifacts/ artifacts/
**/Properties/launchSettings.json **/Properties/launchSettings.json
#VS outout folders
bin
obj
output/*
# macOS metadata files # macOS metadata files
._* ._*
.DS_Store .DS_Store

View file

@ -3,18 +3,18 @@ import React from 'react';
import albumEntities from 'Album/albumEntities'; import albumEntities from 'Album/albumEntities';
import AlbumSearchCellConnector from 'Album/AlbumSearchCellConnector'; import AlbumSearchCellConnector from 'Album/AlbumSearchCellConnector';
import AlbumTitleLink from 'Album/AlbumTitleLink'; import AlbumTitleLink from 'Album/AlbumTitleLink';
// import EpisodeStatusConnector from 'Album/EpisodeStatusConnector'; import EpisodeStatusConnector from 'Album/EpisodeStatusConnector';
import ArtistNameLink from 'Artist/ArtistNameLink'; import ArtistNameLink from 'Artist/ArtistNameLink';
import RelativeDateCellConnector from 'Components/Table/Cells/RelativeDateCellConnector'; import RelativeDateCellConnector from 'Components/Table/Cells/RelativeDateCellConnector';
import TableRowCell from 'Components/Table/Cells/TableRowCell'; import TableRowCell from 'Components/Table/Cells/TableRowCell';
import TableSelectCell from 'Components/Table/Cells/TableSelectCell'; import TableSelectCell from 'Components/Table/Cells/TableSelectCell';
import TableRow from 'Components/Table/TableRow'; import TableRow from 'Components/Table/TableRow';
// import styles from './CutoffUnmetRow.css'; import styles from './CutoffUnmetRow.css';
function CutoffUnmetRow(props) { function CutoffUnmetRow(props) {
const { const {
id, id,
// trackFileId, trackFileId,
artist, artist,
releaseDate, releaseDate,
foreignAlbumId, foreignAlbumId,
@ -99,20 +99,20 @@ function CutoffUnmetRow(props) {
); );
} }
// if (name === 'status') { if (name === 'status') {
// return ( return (
// <TableRowCell <TableRowCell
// key={name} key={name}
// className={styles.status} className={styles.status}
// > >
// <EpisodeStatusConnector <EpisodeStatusConnector
// albumId={id} albumId={id}
// trackFileId={trackFileId} trackFileId={trackFileId}
// albumEntity={albumEntities.WANTED_CUTOFF_UNMET} albumEntity={albumEntities.WANTED_CUTOFF_UNMET}
// /> />
// </TableRowCell> </TableRowCell>
// ); );
// } }
if (name === 'actions') { if (name === 'actions') {
return ( return (
@ -136,7 +136,7 @@ function CutoffUnmetRow(props) {
CutoffUnmetRow.propTypes = { CutoffUnmetRow.propTypes = {
id: PropTypes.number.isRequired, id: PropTypes.number.isRequired,
// trackFileId: PropTypes.number, trackFileId: PropTypes.number,
artist: PropTypes.object.isRequired, artist: PropTypes.object.isRequired,
releaseDate: PropTypes.string.isRequired, releaseDate: PropTypes.string.isRequired,
foreignAlbumId: PropTypes.string.isRequired, foreignAlbumId: PropTypes.string.isRequired,