github/lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/lidarr.git synced 2025-08-14 02:37:08 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fixed: Correctly delete trackfiles on AlbumDeletedEvent

Browse source 
GetFilesByAlbum performs a join on the album releases under the hood,
which won't be populated once the album is deleted.  Fix by providing
a special delete method which omits the join and just looks at albumId.
This commit is contained in:
ta264 2019-06-26 21:57:31 +01:00
commit 447bf63a4d
3 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/NzbDrone.Core.Test/MediaFiles/MediaFileRepositoryFixture.cs
View file

@ -6,6 +6,7 @@ using NzbDrone.Core.Qualities;
using NzbDrone.Core.Music;
using NzbDrone.Core.Test.Framework;
using System.Collections.Generic;
using System.Linq;
namespace NzbDrone.Core.Test.MediaFiles
{
@ -140,5 +141,14 @@ namespace NzbDrone.Core.Test.MediaFiles
file.Artist.Value.Metadata.Value.Should().NotBeNull();
}
}
[Test]
public void delete_files_by_album_should_work_if_join_fails()
{
Db.Delete(album);
Subject.DeleteFilesByAlbum(album.Id);
Db.All<TrackFile>().Where(x => x.AlbumId == album.Id).Should().HaveCount(0);
}
}
}

7
src/NzbDrone.Core/MediaFiles/MediaFileRepository.cs
View file

@ -14,6 +14,7 @@ namespace NzbDrone.Core.MediaFiles
List<TrackFile> GetFilesByRelease(int releaseId);
List<TrackFile> GetFilesWithBasePath(string path);
TrackFile GetFileWithPath(string path);
void DeleteFilesByAlbum(int albumId);
}
@ -51,6 +52,12 @@ namespace NzbDrone.Core.MediaFiles
.ToList();
}
public void DeleteFilesByAlbum(int albumId)
{
var ids = DataMapper.Query<TrackFile>().Where(x => x.AlbumId == albumId);
DeleteMany(ids);
}
public List<TrackFile> GetFilesByRelease(int releaseId)
{
return Query

3
src/NzbDrone.Core/MediaFiles/MediaFileService.cs
View file

@ -148,8 +148,7 @@ namespace NzbDrone.Core.MediaFiles
public void HandleAsync(AlbumDeletedEvent message)
{
var files = GetFilesByAlbum(message.Album.Id);
_mediaFileRepository.DeleteMany(files);
_mediaFileRepository.DeleteFilesByAlbum(message.Album.Id);
}
public List<TrackFile> GetFilesByArtist(int artistId)