github/lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/lidarr.git synced 2025-08-20 21:43:33 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Revert "New: Preserve replaygain tags"

Browse source 
This reverts commit 2a8c67badc.
This commit is contained in:
Bogdan 2024-02-12 22:11:25 +02:00
commit 27723eb3ea
2 changed files with 1 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

34
src/NzbDrone.Core.Test/MediaFiles/AudioTagServiceFixture.cs
View file

@ -330,7 +330,7 @@ namespace NzbDrone.Core.Test.MediaFiles.AudioTagServiceFixture
[Test] [Test]
public void should_ignore_non_parsable_id3v23_date() public void should_ignore_non_parsable_id3v23_date()
{ {
GivenFileCopy("nin.mp3"); GivenFileCopy("nin.mp2");
using (var file = TagLib.File.Create(_copiedFile)) using (var file = TagLib.File.Create(_copiedFile))
{ {
@ -444,37 +444,5 @@ namespace NzbDrone.Core.Test.MediaFiles.AudioTagServiceFixture
Mocker.GetMock<IEventAggregator>() Mocker.GetMock<IEventAggregator>()
.Verify(v => v.PublishEvent(It.IsAny<TrackFileRetaggedEvent>()), Times.Once()); .Verify(v => v.PublishEvent(It.IsAny<TrackFileRetaggedEvent>()), Times.Once());
} }
[TestCase("nin.mp3")]
public void should_ignore_replaygain_tags_during_scrub(string filename)
{
Mocker.GetMock<IConfigService>()
.Setup(x => x.ScrubAudioTags)
.Returns(true);
GivenFileCopy(filename);
using (var preFile = TagLib.File.Create(_copiedFile))
{
preFile.Tag.ReplayGainAlbumPeak = 1;
preFile.Tag.ReplayGainAlbumGain = 500;
preFile.Tag.ReplayGainTrackPeak = 2;
preFile.Tag.ReplayGainTrackGain = 250;
preFile.Save();
}
var file = GivenPopulatedTrackfile(0);
file.Path = _copiedFile;
Subject.WriteTags(file, false, true);
using (var postFile = TagLib.File.Create(_copiedFile))
{
postFile.Tag.ReplayGainAlbumGain.Should().Be(500);
postFile.Tag.ReplayGainAlbumPeak.Should().Be(1);
postFile.Tag.ReplayGainTrackGain.Should().Be(250);
postFile.Tag.ReplayGainTrackPeak.Should().Be(2);
}
}
} }
} }

16
src/NzbDrone.Core/MediaFiles/AudioTagService.cs
View file

@ -155,24 +155,8 @@ namespace NzbDrone.Core.MediaFiles
try try
{ {
file = TagLib.File.Create(path); file = TagLib.File.Create(path);
var replayGainAlbumGain = file.Tag.ReplayGainAlbumGain;
var replayGainAlbumPeak = file.Tag.ReplayGainAlbumPeak;
var replayGainTrackGain = file.Tag.ReplayGainTrackGain;
var replayGainTrackPeak = file.Tag.ReplayGainTrackPeak;
file.RemoveTags(TagLib.TagTypes.AllTags); file.RemoveTags(TagLib.TagTypes.AllTags);
file.Save(); file.Save();
file.Dispose();
file = TagLib.File.Create(path);
file.Tag.ReplayGainAlbumGain = replayGainAlbumGain;
file.Tag.ReplayGainAlbumPeak = replayGainAlbumPeak;
file.Tag.ReplayGainTrackGain = replayGainTrackGain;
file.Tag.ReplayGainTrackPeak = replayGainTrackPeak;
file.Save();
} }
catch (CorruptFileException ex) catch (CorruptFileException ex)
{ {