github/lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/lidarr.git synced 2025-08-19 13:10:13 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix: Quality range definitions in kbps (#157)

Browse source 
* Quality range uses kbits per second. Quality ranges updated for each format

* Changed vorbis q10 weight

* Fixed element name

* Added migration to keep existing MB/min quality constraints valid

* Fixed migration SQL

* Slider step now 1

* Fix: using kbps for min size as well

* Added tooltip for quality-size

* Updated AcceptableSizeSpecification test

* Small magic number fix
This commit is contained in:
Tynan CR 2017-12-27 21:41:11 -05:00 • committed by Qstick
commit 1368dd6a53
10 changed files with 119 additions and 84 deletions
Download patch file Download diff file Expand all files Collapse all files

2
frontend/src/Settings/Quality/Definition/QualityDefinition.css
View file

@ -53,7 +53,7 @@
justify-content: space-between;
}
.megabytesPerMinute {
.kilobitsPerSecond {
display: flex;
justify-content: space-between;
flex: 0 0 250px;

31
frontend/src/Settings/Quality/Definition/QualityDefinition.js
View file

@ -10,8 +10,8 @@ import styles from './QualityDefinition.css';
const slider = {
min: 0,
max: 200,
step: 0.1
max: 1500,
step: 1
};
function getValue(value) {
@ -69,13 +69,16 @@ class QualityDefinition extends Component {
onTitleChange
} = this.props;
const minBytes = minSize * 1024 * 1024;
const minThirty = formatBytes(minBytes * 30, 2);
const minSixty = formatBytes(minBytes * 60, 2);
const minBytes = minSize * 128;
const maxBytes = maxSize && maxSize * 128;
const maxBytes = maxSize && maxSize * 1024 * 1024;
const maxThirty = maxBytes ? formatBytes(maxBytes * 30, 2) : 'Unlimited';
const maxSixty = maxBytes ? formatBytes(maxBytes * 60, 2) : 'Unlimited';
// Calculates the bytes used by a twenty minute EP
const minTwenty = formatBytes(minBytes * 20 * 60, 2);
const maxTwenty = maxBytes ? formatBytes(maxBytes * 20 * 60, 2) : 'Unlimited';
// Calculates the bytes used by a forty-five minute LP
const minFortyFive = formatBytes(minBytes * 45 * 60, 2);
const maxFortyFive = maxBytes ? formatBytes(maxBytes * 45 * 60, 2) : 'Unlimited';
return (
<div className={styles.qualityDefinition}>
@ -108,20 +111,20 @@ class QualityDefinition extends Component {
<div className={styles.sizes}>
<div>
<Label kind={kinds.WARNING}>{minThirty}</Label>
<Label kind={kinds.INFO}>{minSixty}</Label>
<Label title={"Minimum size for a 20 minute EP"} kind={kinds.WARNING}>{minTwenty}</Label>
<Label title={"Minimum size for a 45 minute LP"} kind={kinds.INFO}>{minFortyFive}</Label>
</div>
<div>
<Label kind={kinds.WARNING}>{maxThirty}</Label>
<Label kind={kinds.INFO}>{maxSixty}</Label>
<Label title={"Maximum size for a 20 minute EP"} kind={kinds.WARNING}>{maxTwenty}</Label>
<Label title={"Maximum size for a 45 minute LP"} kind={kinds.INFO}>{maxFortyFive}</Label>
</div>
</div>
</div>
{
advancedSettings &&
<div className={styles.megabytesPerMinute}>
<div className={styles.kilobitsPerSecond}>
<div>
Min
@ -139,7 +142,7 @@ class QualityDefinition extends Component {
<NumberInput
className={styles.sizeInput}
name={`${id}.min`}
name={`${id}.max`}
value={maxSize || slider.max}
isFloat={true}
onChange={this.onMaxSizeChange}

2
frontend/src/Settings/Quality/Definition/QualityDefinitions.css
View file

@ -12,7 +12,7 @@
flex: 0 1 500px;
}
.megabytesPerMinute {
.kilobitsPerSecond {
flex: 0 0 250px;
}

2
frontend/src/Settings/Quality/Definition/QualityDefinitions.js
View file

@ -28,7 +28,7 @@ class QualityDefinitions extends Component {
<div className={styles.quality}>Quality</div>
<div className={styles.title}>Title</div>
<div className={styles.sizeLimit}>Size Limit</div>
<div className={styles.megabytesPerMinute}>Megabytes Per Minute</div>
<div className={styles.kilobitsPerSecond}>Kilobits Per Second</div>
</div>
<div className={styles.definitions}>