Catchup Linting

azure-pipelines.yml

@@ -44,6 +44,9 @@ stages:
 
       pool:
         vmImage: $(imageName)
+      variables:
+        # Disable stylecop here - linting errors get caught by the analyze task
+        EnableAnalyzers: 'false'
       steps:
       # Set the build name properly.  The 'name' property won't recursively expand so hack here:
       - powershell: Write-Host "##vso[build.updatebuildnumber]$($env:LIDARRVERSION)"
@@ -661,8 +664,6 @@ stages:
   - stage: Analyze
     dependsOn: []
     displayName: Analyze
-    condition: eq(variables['system.pullrequest.isfork'], false)
-      
     jobs:
     - job: Lint_Frontend
       displayName: Lint Frontend
@@ -691,6 +692,7 @@ stages:
 
     - job: Analyze_Frontend
       displayName: Frontend
+      condition: eq(variables['System.PullRequest.IsFork'], 'False')
       pool:
         vmImage: windows-2019
       steps:
@@ -711,10 +713,11 @@ stages:
 
     - job: Analyze_Backend
       displayName: Backend
-      pool:
-        vmImage: windows-2019
       variables:
         disable.coverage.autogenerate: 'true'
+      pool:
+        vmImage: windows-2019
+
       steps:
       - task: UseDotNet@2
         displayName: 'Install .net core'
@@ -725,6 +728,7 @@ stages:
       - powershell: Set-Service SCardSvr -StartupType Manual
         displayName: Enable Windows Test Service
       - task: SonarCloudPrepare@1
+        condition: eq(variables['System.PullRequest.IsFork'], 'False')
         inputs:
           SonarCloud: 'SonarCloud'
           organization: 'lidarr'
@@ -742,6 +746,7 @@ stages:
           TEST_DIR=_tests/netcoreapp3.1/win-x64/publish/ ./test.sh Windows Unit Coverage
         displayName: Coverage Unit Tests
       - task: SonarCloudAnalyze@1
+        condition: eq(variables['System.PullRequest.IsFork'], 'False')
         displayName: Publish SonarCloud Results
       - task: reportgenerator@4
         displayName: Generate Coverage Report
@@ -755,14 +760,14 @@ stages:
           codeCoverageTool: 'cobertura'
           summaryFileLocation: './CoverageResults/combined/Cobertura.xml'
           reportDirectory: './CoverageResults/combined/'
-          
+
   - stage: Report_Out
     dependsOn:
     - Analyze
     - Unit_Test
     - Integration
     - Automation
-    condition: always()
+    condition: eq(variables['system.pullrequest.isfork'], false)
     displayName: Build Status Report
     jobs:
     - job: