github/greenshot
1
0
Fork 0
mirror of https://github.com/greenshot/greenshot synced 2025-08-19 04:59:30 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Found some HORRIBLE code, which I used from a blog, where the writer was casting IntPtr's to ints and using it as a pointer. This can (logically) cause huge problems on 64-bit systems!

Browse source 
git-svn-id: http://svn.code.sf.net/p/greenshot/code/trunk@2501 7dccd23d-a4a3-4e1f-8c07-b4c1b4018ab4
This commit is contained in:
RKrom 2013-02-17 18:13:10 +00:00
commit eea9ba6e9e
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Greenshot/Helpers/MailHelper.cs
View file

@ -291,10 +291,10 @@ namespace Greenshot.Helpers {
int fsize = Marshal.SizeOf(fileDescType); int fsize = Marshal.SizeOf(fileDescType);
// Get the ptr to the files // Get the ptr to the files
int runptr = (int)message.Files; IntPtr runptr = message.Files.Clone();
// Release each file // Release each file
for (int i = 0; i < message.FileCount; i++) { for (int i = 0; i < message.FileCount; i++) {
Marshal.DestroyStructure((IntPtr)runptr, fileDescType); Marshal.DestroyStructure(runptr, fileDescType);
runptr += fsize; runptr += fsize;
} }
// Release the file // Release the file
@ -322,12 +322,12 @@ namespace Greenshot.Helpers {
MapiFileDescriptor mfd = new MapiFileDescriptor(); MapiFileDescriptor mfd = new MapiFileDescriptor();
mfd.position = -1; mfd.position = -1;
int runptr = (int)ptra; IntPtr runptr = ptra.Clone();
for (int i = 0; i < _files.Count; i++) { for (int i = 0; i < _files.Count; i++) {
string path = _files[i] as string; string path = _files[i] as string;
mfd.name = Path.GetFileName(path); mfd.name = Path.GetFileName(path);
mfd.path = path; mfd.path = path;
Marshal.StructureToPtr(mfd, (IntPtr)runptr, false); Marshal.StructureToPtr(mfd, runptr, false);
runptr += asize; runptr += asize;
} }
@ -687,12 +687,12 @@ namespace Greenshot.Helpers {
_handle = Marshal.AllocHGlobal(_count * size); _handle = Marshal.AllocHGlobal(_count * size);
// place all interop recipients into the memory just allocated // place all interop recipients into the memory just allocated
int ptr = (int)_handle; IntPtr ptr = _handle.Clone();
foreach (Recipient native in outer) { foreach (Recipient native in outer) {
MapiMailMessage.MAPIHelperInterop.MapiRecipDesc interop = native.GetInteropRepresentation(); MapiMailMessage.MAPIHelperInterop.MapiRecipDesc interop = native.GetInteropRepresentation();
// stick it in the memory block // stick it in the memory block
Marshal.StructureToPtr(interop, (IntPtr)ptr, false); Marshal.StructureToPtr(interop, ptr, false);
ptr += size; ptr += size;
} }
} }
@ -720,9 +720,9 @@ namespace Greenshot.Helpers {
int size = Marshal.SizeOf(type); int size = Marshal.SizeOf(type);
// destroy all the structures in the memory area // destroy all the structures in the memory area
int ptr = (int)_handle; IntPtr ptr = _handle.Clone();
for (int i = 0; i < _count; i++) { for (int i = 0; i < _count; i++) {
Marshal.DestroyStructure((IntPtr)ptr, type); Marshal.DestroyStructure(ptr, type);
ptr += size; ptr += size;
} }