From cd190b1c07ace2f0154d46317f85b6fcbe8765cd Mon Sep 17 00:00:00 2001 From: RKrom Date: Fri, 17 Feb 2012 10:00:44 +0000 Subject: [PATCH] Fixed bug when using the editor button "export to outlook", closures & foreach variables don't mix! git-svn-id: http://svn.code.sf.net/p/greenshot/code/trunk@1662 7dccd23d-a4a3-4e1f-8c07-b4c1b4018ab4 --- Greenshot/Forms/ImageEditorForm.cs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Greenshot/Forms/ImageEditorForm.cs b/Greenshot/Forms/ImageEditorForm.cs index ff446bbc6..b3d3e2d32 100644 --- a/Greenshot/Forms/ImageEditorForm.cs +++ b/Greenshot/Forms/ImageEditorForm.cs @@ -196,11 +196,12 @@ namespace Greenshot { if (subDestinations.Count > 0) { subDestinations.Sort(); foreach(IDestination subDestination in subDestinations) { - ToolStripMenuItem destinationMenuItem = new ToolStripMenuItem(subDestination.Description); - destinationMenuItem.Tag = subDestination; - destinationMenuItem.Image = subDestination.DisplayIcon; + IDestination closureFixedDestination = subDestination; + ToolStripMenuItem destinationMenuItem = new ToolStripMenuItem(closureFixedDestination.Description); + destinationMenuItem.Tag = closureFixedDestination; + destinationMenuItem.Image = closureFixedDestination.DisplayIcon; destinationMenuItem.Click += delegate { - subDestination.ExportCapture(surface, surface.CaptureDetails); + closureFixedDestination.ExportCapture(surface, surface.CaptureDetails); }; destinationButton.DropDownItems.Add(destinationMenuItem); }