Code quality fixes (NullReference checks, unused variables etc)

This commit is contained in:
RKrom 2014-04-26 00:34:06 +02:00
parent 6ab6033f85
commit ac08533727
99 changed files with 1252 additions and 1312 deletions

View file

@ -20,18 +20,17 @@
*/
using System.ComponentModel;
using System.Drawing;
using Greenshot.IniFile;
using Greenshot.Plugin;
using GreenshotPlugin.Core;
using log4net;
namespace GreenshotBoxPlugin {
public class BoxDestination : AbstractDestination {
private static log4net.ILog LOG = log4net.LogManager.GetLogger(typeof(BoxDestination));
private static BoxConfiguration config = IniConfig.GetIniSection<BoxConfiguration>();
private static ILog LOG = LogManager.GetLogger(typeof(BoxDestination));
private BoxPlugin plugin = null;
private readonly BoxPlugin _plugin;
public BoxDestination(BoxPlugin plugin) {
this.plugin = plugin;
_plugin = plugin;
}
public override string Designation {
@ -54,8 +53,8 @@ namespace GreenshotBoxPlugin {
}
public override ExportInformation ExportCapture(bool manuallyInitiated, ISurface surface, ICaptureDetails captureDetails) {
ExportInformation exportInformation = new ExportInformation(this.Designation, this.Description);
string uploadUrl = plugin.Upload(captureDetails, surface);
ExportInformation exportInformation = new ExportInformation(Designation, Description);
string uploadUrl = _plugin.Upload(captureDetails, surface);
if (uploadUrl != null) {
exportInformation.ExportMade = true;
exportInformation.Uri = uploadUrl;