From abad0a216609c067f07d38fd9b11fe8c519a951a Mon Sep 17 00:00:00 2001
From: RKrom <robin@getgreenshot.org>
Date: Fri, 6 Apr 2012 15:49:50 +0000
Subject: [PATCH] Fixed transparency issue: it wasn't removed before storing
 images without transparency support.

git-svn-id: http://svn.code.sf.net/p/greenshot/code/trunk@1760 7dccd23d-a4a3-4e1f-8c07-b4c1b4018ab4
---
 Greenshot/Helpers/ImageOutput.cs | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/Greenshot/Helpers/ImageOutput.cs b/Greenshot/Helpers/ImageOutput.cs
index 4403b47a3..0e2e1e382 100644
--- a/Greenshot/Helpers/ImageOutput.cs
+++ b/Greenshot/Helpers/ImageOutput.cs
@@ -105,6 +105,12 @@ namespace Greenshot.Helpers {
 				reduceColors = true;
 			}
 
+			// Removing transparency if it's not supported
+			if (imageFormat != ImageFormat.Png) {
+				imageToSave = ImageHelper.Clone(imageToSave, PixelFormat.Format24bppRgb);
+				disposeImage = true;
+			}
+
 			// check for color reduction, forced or automatically
 			if (conf.OutputFileAutoReduceColors || reduceColors) {
 				WuQuantizer quantizer = new WuQuantizer((Bitmap)imageToSave);
@@ -113,7 +119,11 @@ namespace Greenshot.Helpers {
 				if (reduceColors || colorCount < 256) {
 					try {
 						LOG.Info("Reducing colors on bitmap to 255.");
-						imageToSave = quantizer.GetQuantizedImage(255);
+						Image tmpImage = quantizer.GetQuantizedImage(255);
+						if (disposeImage) {
+							imageToSave.Dispose();
+						}
+						imageToSave = tmpImage;
 						// Make sure the "new" image is disposed
 						disposeImage = true;
 					} catch (Exception e) {
@@ -134,7 +144,7 @@ namespace Greenshot.Helpers {
 						LOG.WarnFormat("Image of type {0} do not support property {1}", imageFormat, softwareUsedPropertyItem.Id);
 					}
 				}
-				LOG.DebugFormat("Saving image to stream with PixelFormat {0}", imageToSave.PixelFormat);
+				LOG.DebugFormat("Saving image to stream with Format {0} and PixelFormat {1}", imageFormat, imageToSave.PixelFormat);
 				if (imageFormat == ImageFormat.Jpeg) {
 					EncoderParameters parameters = new EncoderParameters(1);
 					parameters.Param[0] = new System.Drawing.Imaging.EncoderParameter(Encoder.Quality, quality);