github/greenshot
1
0
Fork 0
mirror of https://github.com/greenshot/greenshot synced 2025-07-15 01:23:47 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Found a bug in the default configuration for DWM/GDI capturing while suggesting a workaround for Bug #1623, fixed this by correcting the value in code.

Browse source
This commit is contained in:
RKrom 2014-04-30 10:30:42 +02:00
parent f7809b9088
commit 97297c2c69
1 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

24
GreenshotPlugin/Core/CoreConfiguration.cs
View file

@ -185,9 +185,9 @@ namespace GreenshotPlugin.Core {
[IniProperty("ThumnailPreview", Description="Enable/disable thumbnail previews", DefaultValue="True")] [IniProperty("ThumnailPreview", Description="Enable/disable thumbnail previews", DefaultValue="True")]
public bool ThumnailPreview; public bool ThumnailPreview;
[IniProperty("NoGDICaptureForProduct", Description="List of products for which GDI capturing doesn't work.", DefaultValue="IntelliJ,IDEA")] [IniProperty("NoGDICaptureForProduct", Description = "List of productnames for which GDI capturing is skipped (using fallback).", DefaultValue = "IntelliJ IDEA")]
public List<string> NoGDICaptureForProduct; public List<string> NoGDICaptureForProduct;
[IniProperty("NoDWMCaptureForProduct", Description="List of products for which DWM capturing doesn't work.", DefaultValue="Citrix,ICA,Client")] [IniProperty("NoDWMCaptureForProduct", Description = "List of productnames for which DWM capturing is skipped (using fallback).", DefaultValue = "Citrix ICA Client")]
public List<string> NoDWMCaptureForProduct; public List<string> NoDWMCaptureForProduct;
[IniProperty("OptimizeForRDP", Description="Make some optimizations for usage with remote desktop", DefaultValue="False")] [IniProperty("OptimizeForRDP", Description="Make some optimizations for usage with remote desktop", DefaultValue="False")]
@ -380,10 +380,11 @@ namespace GreenshotPlugin.Core {
// Make sure the lists are lowercase, to speedup the check // Make sure the lists are lowercase, to speedup the check
if (NoGDICaptureForProduct != null) { if (NoGDICaptureForProduct != null) {
// Fix error in configuration // Fix error in configuration
if (NoGDICaptureForProduct.Count == 1) { if (NoGDICaptureForProduct.Count >= 2) {
if ("intellij idea".Equals(NoGDICaptureForProduct[0])) { if ("intellij".Equals(NoGDICaptureForProduct[0]) && "idea".Equals(NoGDICaptureForProduct[1])) {
NoGDICaptureForProduct[0] = "intellij,idea"; NoGDICaptureForProduct.RemoveRange(0, 2);
this.IsDirty = true; NoGDICaptureForProduct.Add("Intellij Idea");
IsDirty = true;
} }
} }
for (int i = 0; i < NoGDICaptureForProduct.Count; i++) { for (int i = 0; i < NoGDICaptureForProduct.Count; i++) {
@ -392,13 +393,14 @@ namespace GreenshotPlugin.Core {
} }
if (NoDWMCaptureForProduct != null) { if (NoDWMCaptureForProduct != null) {
// Fix error in configuration // Fix error in configuration
if (NoDWMCaptureForProduct.Count == 1) { if (NoDWMCaptureForProduct.Count >= 3) {
if ("citrix ica client".Equals(NoDWMCaptureForProduct[0])) { if ("citrix".Equals(NoDWMCaptureForProduct[0]) && "ica".Equals(NoDWMCaptureForProduct[1]) && "client".Equals(NoDWMCaptureForProduct[2])) {
NoDWMCaptureForProduct[0] = "citrix,ica,client"; NoDWMCaptureForProduct.RemoveRange(0, 3);
this.IsDirty = true; NoDWMCaptureForProduct.Add("Citrix ICA Client");
IsDirty = true;
} }
} }
for(int i=0; i< NoDWMCaptureForProduct.Count; i++) { for (int i = 0; i < NoDWMCaptureForProduct.Count; i++) {
NoDWMCaptureForProduct[i] = NoDWMCaptureForProduct[i].ToLower(); NoDWMCaptureForProduct[i] = NoDWMCaptureForProduct[i].ToLower();
} }
} }