github/greenshot
1
0
Fork 0
mirror of https://github.com/greenshot/greenshot synced 2025-07-16 10:03:44 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix in CallExternalCommand: Exception message "Error calling external command" was shown although CallExternalCommand has finished successful.

Browse source 
In addition log4net message has been written before exportInformation.ErrorMessage was set, so exception message was not in log file.
This commit is contained in:
viper3400 2015-10-03 16:33:55 +02:00
parent 4290333997
commit 92ca39f621
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
GreenshotExternalCommandPlugin/ExternalCommandDestination.cs
View file

@ -121,7 +121,7 @@ namespace ExternalCommand {
if (config.OutputToClipboard) {
ClipboardHelper.SetClipboardData(output);
}
if (uriMatches != null && uriMatches.Count >= 0) {
if (uriMatches != null && uriMatches.Count > 0) {
exportInformation.Uri = uriMatches[0].Groups[1].Value;
LOG.InfoFormat("Got URI : {0} ", exportInformation.Uri);
if (config.UriToClipboard) {
@ -134,10 +134,10 @@ namespace ExternalCommand {
exportInformation.ExportMade = false;
exportInformation.ErrorMessage = error;
}
} catch (Exception ex) {
LOG.WarnFormat("Error calling external command: {0} ", exportInformation.ErrorMessage);
} catch (Exception ex) {
exportInformation.ExportMade = false;
exportInformation.ErrorMessage = ex.Message;
LOG.WarnFormat("Error calling external command: {0} ", exportInformation.ErrorMessage);
}
}