Improving stability for the notification issue reported in #182

GreenshotPlugin/Core/SimpleServiceProvider.cs

@@ -43,6 +43,10 @@ namespace GreenshotPlugin.Core
 
             foreach (var service in services)
             {
+                if (service == null)
+                {
+                    continue;
+                }
                 currentServices.Add(service);
             }
         }

GreenshotWin10Plugin/ToastNotificationService.cs

@@ -23,6 +23,7 @@ using System;
 using System.Drawing.Imaging;
 using System.IO;
 using System.Linq;
+using Windows.Foundation.Metadata;
 using Windows.UI.Notifications;
 using GreenshotPlugin.Core;
 using GreenshotPlugin.IniFile;
@@ -149,7 +150,14 @@ namespace GreenshotWin10Plugin
             }
             toast.Dismissed += ToastDismissedHandler;
             toast.Failed += ToastOnFailed;
-            toastNotifier.Show(toast);
+            try
+            {
+                toastNotifier.Show(toast);
+            }
+            catch (Exception ex)
+            {
+                Log.Error("Couldn't show notification.", ex);
+            }
         }
 
         private void ToastOnFailed(ToastNotification sender, ToastFailedEventArgs args)
@@ -172,5 +180,20 @@ namespace GreenshotWin10Plugin
         {
             ShowMessage(message, timeout, onClickAction, onClosedAction);
         }
+
+        /// <summary>
+        /// Factory method, helping with checking if the notification service is even available
+        /// </summary>
+        /// <returns>ToastNotificationService</returns>
+        public static ToastNotificationService Create()
+        {
+            if (ApiInformation.IsTypePresent("Windows.ApplicationModel.Background.ToastNotificationActionTrigger"))
+            {
+                return new ToastNotificationService();
+            }
+            Log.Warn("ToastNotificationActionTrigger not available.");
+
+            return null;
+        }
     }
 }

GreenshotWin10Plugin/Win10Plugin.cs

@@ -63,7 +63,7 @@ namespace GreenshotWin10Plugin
                 return false;
             }
 
-            SimpleServiceProvider.Current.AddService<INotificationService>(new ToastNotificationService());
+            SimpleServiceProvider.Current.AddService<INotificationService>(ToastNotificationService.Create());
 			// Set this as IOcrProvider
 			SimpleServiceProvider.Current.AddService<IOcrProvider>(new Win10OcrProvider());
             // Add the processor