github/greenshot
1
0
Fork 0
mirror of https://github.com/greenshot/greenshot synced 2025-08-21 05:53:27 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improved the readability of the ToolStripMenuSelectList, no longer using public fields but Properties and now it uses the right types.

Browse source
This commit is contained in:
RKrom 2014-11-03 08:45:09 +01:00
commit 7fdd324ef0
1 changed files with 32 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

42
Greenshot/Forms/ToolStripMenuSelectList.cs
View file

@ -18,6 +18,7 @@
* You should have received a copy of the GNU General Public License * You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>. * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
using System; using System;
using System.Collections; using System.Collections;
using System.Collections.Generic; using System.Collections.Generic;
@ -26,7 +27,7 @@ using System.Windows.Forms;
namespace Greenshot.Forms { namespace Greenshot.Forms {
/// <summary> /// <summary>
/// Description of ToolStripMenuSelectList. /// the ToolStripMenuSelectList makes it possible to have a single or multi-check menu
/// </summary> /// </summary>
public class ToolStripMenuSelectList : ToolStripMenuItem { public class ToolStripMenuSelectList : ToolStripMenuItem {
private bool multiCheckAllowed = false; private bool multiCheckAllowed = false;
@ -35,10 +36,12 @@ namespace Greenshot.Forms {
/// Occurs when one of the list's child element's Checked state changes. /// Occurs when one of the list's child element's Checked state changes.
/// </summary> /// </summary>
public new event EventHandler CheckedChanged; public new event EventHandler CheckedChanged;
public Object Identifier; public object Identifier {
get;
private set;
}
public ToolStripMenuSelectList(object identifier, bool allowMultiCheck) {
public ToolStripMenuSelectList(Object identifier, bool allowMultiCheck) {
Identifier = identifier; Identifier = identifier;
CheckOnClick = false; CheckOnClick = false;
multiCheckAllowed = allowMultiCheck; multiCheckAllowed = allowMultiCheck;
@ -49,12 +52,12 @@ namespace Greenshot.Forms {
/// <summary> /// <summary>
/// gets or sets the currently checked item /// gets or sets the currently checked item
/// </summary> /// </summary>
public Object CheckedItem { public ToolStripMenuSelectListItem CheckedItem {
get { get {
IEnumerator items = DropDownItems.GetEnumerator(); IEnumerator items = DropDownItems.GetEnumerator();
while (items.MoveNext()) { while (items.MoveNext()) {
ToolStripMenuItem tsmi = (ToolStripMenuItem)items.Current; ToolStripMenuSelectListItem tsmi = (ToolStripMenuSelectListItem)items.Current;
if (tsmi.Checked) { if (tsmi.Checked) {
return tsmi; return tsmi;
} }
@ -64,7 +67,7 @@ namespace Greenshot.Forms {
set { set {
IEnumerator items = DropDownItems.GetEnumerator(); IEnumerator items = DropDownItems.GetEnumerator();
while (items.MoveNext()) { while (items.MoveNext()) {
ToolStripMenuItem tsmi = (ToolStripMenuItem)items.Current; ToolStripMenuSelectListItem tsmi = (ToolStripMenuSelectListItem)items.Current;
if (!multiCheckAllowed && !tsmi.Equals(value)) { if (!multiCheckAllowed && !tsmi.Equals(value)) {
tsmi.Checked = false; tsmi.Checked = false;
} else if (tsmi.Equals(value)) { } else if (tsmi.Equals(value)) {
@ -96,7 +99,7 @@ namespace Greenshot.Forms {
IEnumerator items = DropDownItems.GetEnumerator(); IEnumerator items = DropDownItems.GetEnumerator();
IEnumerator sel = value.GetEnumerator(); IEnumerator sel = value.GetEnumerator();
while (items.MoveNext()) { while (items.MoveNext()) {
ToolStripMenuItem tsmi = (ToolStripMenuItem)items.Current; ToolStripMenuSelectListItem tsmi = (ToolStripMenuSelectListItem)items.Current;
while (sel.MoveNext()) { while (sel.MoveNext()) {
if (tsmi.Equals(sel.Current)) { if (tsmi.Equals(sel.Current)) {
tsmi.Checked = true; tsmi.Checked = true;
@ -217,21 +220,34 @@ namespace Greenshot.Forms {
public void UncheckAll() { public void UncheckAll() {
IEnumerator items = DropDownItems.GetEnumerator(); IEnumerator items = DropDownItems.GetEnumerator();
while (items.MoveNext()) { while (items.MoveNext()) {
((ToolStripMenuItem)items.Current).Checked = false; ((ToolStripMenuSelectListItem)items.Current).Checked = false;
} }
} }
} }
/// <summary>
/// Event class for the CheckedChanged event in the ToolStripMenuSelectList
/// </summary>
public class ItemCheckedChangedEventArgs : EventArgs { public class ItemCheckedChangedEventArgs : EventArgs {
public ToolStripMenuSelectListItem Item; public ToolStripMenuSelectListItem Item {
get;
set;
}
public ItemCheckedChangedEventArgs(ToolStripMenuSelectListItem item) { public ItemCheckedChangedEventArgs(ToolStripMenuSelectListItem item) {
Item = item; Item = item;
} }
} }
/// <summary>
/// Wrapper around the ToolStripMenuItem, which can contain an object
/// Also the Checked property hides the normal checked property so we can render our own check
/// </summary>
public class ToolStripMenuSelectListItem : ToolStripMenuItem { public class ToolStripMenuSelectListItem : ToolStripMenuItem {
public Object Data;
} public object Data {
get;
set;
} }
}
}