FEATURE-766: Region capture: When keeping the Ctrl key pressed, and using the cursor keys, the cursor is now moved 10 pixels. Also added the possibility to start / end the region selection with the enter key.

Greenshot/Forms/CaptureForm.cs

@@ -72,6 +72,8 @@ namespace Greenshot.Forms {
 		private RectangleAnimator _windowAnimator;
 		private RectangleAnimator _zoomAnimator;
 		private readonly bool _isZoomerTransparent = Conf.ZoomerOpacity < 1;
+		private bool _isCtrlPressed = false;
+
 		/// <summary>
 		/// Property to access the selected capture rectangle
 		/// </summary>
@@ -192,8 +194,13 @@ namespace Greenshot.Forms {
 
 		#region key handling		
 		void CaptureFormKeyUp(object sender, KeyEventArgs e) {
-			if (e.KeyCode == Keys.ShiftKey) {
+			switch(e.KeyCode) {
+				case Keys.ShiftKey:
 					_fixMode = FixMode.None;
+					break;
+				case Keys.ControlKey:
+					_isCtrlPressed = false;
+					break;
 			}
 		}
 
@@ -203,18 +210,20 @@ namespace Greenshot.Forms {
 		/// <param name="sender"></param>
 		/// <param name="e"></param>
 		void CaptureFormKeyDown(object sender, KeyEventArgs e) {
+			int step = _isCtrlPressed ? 10 : 1;
+
 			switch (e.KeyCode) {
 				case Keys.Up:
-					Cursor.Position = new Point(Cursor.Position.X, Cursor.Position.Y - 1);
+					Cursor.Position = new Point(Cursor.Position.X, Cursor.Position.Y - step);
 					break;
 				case Keys.Down:
-					Cursor.Position = new Point(Cursor.Position.X, Cursor.Position.Y + 1);
+					Cursor.Position = new Point(Cursor.Position.X, Cursor.Position.Y + step);
 					break;
 				case Keys.Left:
-					Cursor.Position = new Point(Cursor.Position.X - 1, Cursor.Position.Y);
+					Cursor.Position = new Point(Cursor.Position.X - step, Cursor.Position.Y);
 					break;
 				case Keys.Right:
-					Cursor.Position = new Point(Cursor.Position.X + 1, Cursor.Position.Y);
+					Cursor.Position = new Point(Cursor.Position.X + step, Cursor.Position.Y);
 					break;
 				case Keys.ShiftKey:
 					// Fixmode
@@ -222,6 +231,9 @@ namespace Greenshot.Forms {
 						_fixMode = FixMode.Initiated;
 					}
 					break;
+				case Keys.ControlKey:
+					_isCtrlPressed = true;
+					break;
 				case Keys.Escape:
 					// Cancel
 					DialogResult = DialogResult.Cancel;
@@ -280,6 +292,10 @@ namespace Greenshot.Forms {
 					// Confirm
 					if (_captureMode == CaptureMode.Window) {
 						DialogResult = DialogResult.OK;
+					} else if (!_mouseDown) {
+						HandleMouseDown();
+					} else if (_mouseDown) {
+						HandleMouseUp();
 					}
 					break;
 			}
@@ -294,22 +310,20 @@ namespace Greenshot.Forms {
 		/// <param name="e"></param>
 		void OnMouseDown(object sender, MouseEventArgs e) {
 			if (e.Button == MouseButtons.Left) {
+				HandleMouseDown();
+			}
+		}
+
+		private void HandleMouseDown() {
 			Point tmpCursorLocation = WindowCapture.GetCursorLocationRelativeToScreenBounds();
 			_mX = tmpCursorLocation.X;
 			_mY = tmpCursorLocation.Y;
 			_mouseDown = true;
-				OnMouseMove(this, e);
+			OnMouseMove(this, null);
 			Invalidate();
 		}
-		}
 
-		/// <summary>
+		private void HandleMouseUp() {
-		/// The mouse up handler of the capture form
-		/// </summary>
-		/// <param name="sender"></param>
-		/// <param name="e"></param>
-		void OnMouseUp(object sender, MouseEventArgs e) {
-			if (_mouseDown) {
 			// If the mouse goes up we set down to false (nice logic!)
 			_mouseDown = false;
 			// Check if anything is selected
@@ -327,6 +341,17 @@ namespace Greenshot.Forms {
 			} else {
 				Invalidate();
 			}
+
+		}
+		
+		/// <summary>
+		/// The mouse up handler of the capture form
+		/// </summary>
+		/// <param name="sender"></param>
+		/// <param name="e"></param>
+		void OnMouseUp(object sender, MouseEventArgs e) {
+			if (_mouseDown) {
+				HandleMouseUp();
 			}
 		}
 		

Greenshot/releases/additional_files/readme.txt.template

@@ -7,6 +7,16 @@ CHANGE LOG:
 
 @DETAILVERSION@
 
+Features:
+* Due to BUG-1667 we had to remove the horizontal text alignment, this afflicts the textbox and the speech bubble.
+* Added the possibility to select the region to capture by using the keyboard, use the cursor keys to move the cursor (ctrl-key speeds up the movement) and the enter key to mark the start and ending.
+
+Bugs Resolved:
+* BUG-1667 removed horizontal alignment of textbox in input mode, as it caused problems with textbox focus and could not be implemented consistently anyway (no vertical alignment possible)
+
+
+1.2.1.2-af946cf RC1
+
 All details to our tickets can be found here: https://greenshot.atlassian.net
 
 Features: