github/greenshot
1
0
Fork 0
mirror of https://github.com/greenshot/greenshot synced 2025-08-22 06:23:24 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor adjustCoordsForRationalScale to Get Rid of Code Duplication and Improve Comprehensibility

Browse source
This commit is contained in:
jklingen 2021-03-27 17:39:31 +01:00
commit 13e91104e1
1 changed files with 49 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

120
Greenshot/Helpers/ScaleHelper.cs
View file

@ -227,92 +227,70 @@ namespace Greenshot.Helpers {
/// <param name="resizeHandlePosition">position of the handle/gripper being used for resized, see Position</param> /// <param name="resizeHandlePosition">position of the handle/gripper being used for resized, see Position</param>
/// <param name="resizeHandleCoords">coordinates of the used handle/gripper, adjusted coordinates will be written to this reference</param> /// <param name="resizeHandleCoords">coordinates of the used handle/gripper, adjusted coordinates will be written to this reference</param>
private static void adjustCoordsForRationalScale(RectangleF originalRectangle, Positions resizeHandlePosition, ref PointF resizeHandleCoords) { private static void adjustCoordsForRationalScale(RectangleF originalRectangle, Positions resizeHandlePosition, ref PointF resizeHandleCoords) {
float originalRatio = originalRectangle.Width / originalRectangle.Height; SizeF selectedRectangle, newSize;
float newWidth, newHeight, newRatio;
int flippedRatioSign;
switch(resizeHandlePosition) { switch(resizeHandlePosition) {
case Positions.TopLeft: case Positions.TopLeft:
newWidth = originalRectangle.Right - resizeHandleCoords.X; selectedRectangle = new SizeF(originalRectangle.Right - resizeHandleCoords.X, originalRectangle.Bottom - resizeHandleCoords.Y);
newHeight = originalRectangle.Bottom - resizeHandleCoords.Y; newSize = getNewSizeForRationalScale(originalRectangle.Size, selectedRectangle);
newRatio = newWidth / newHeight; resizeHandleCoords.X = originalRectangle.Right - newSize.Width;
flippedRatioSign = Math.Sign(newRatio) * Math.Sign(originalRatio); resizeHandleCoords.Y = originalRectangle.Bottom - newSize.Height;
if (Math.Abs(newRatio) > Math.Abs(originalRatio)) {
// scaled rectangle (ratio) would be wider than original
// keep height and tweak width to maintain aspect ratio
float tweakedWidth = newHeight * originalRatio * flippedRatioSign;
resizeHandleCoords.X = originalRectangle.Right - tweakedWidth;
} else if(Math.Abs(newRatio) < Math.Abs(originalRatio)) {
// scaled rectangle (ratio) would be taller than original
// keep width and tweak height to maintain aspect ratio
float tweakedHeight = newWidth / originalRatio * flippedRatioSign;
resizeHandleCoords.Y = originalRectangle.Bottom - tweakedHeight;
}
break; break;
case Positions.TopRight: case Positions.TopRight:
newWidth = resizeHandleCoords.X - originalRectangle.Left; selectedRectangle = new SizeF(resizeHandleCoords.X - originalRectangle.Left, originalRectangle.Bottom - resizeHandleCoords.Y);
newHeight = originalRectangle.Bottom - resizeHandleCoords.Y; newSize = getNewSizeForRationalScale(originalRectangle.Size, selectedRectangle);
newRatio = newWidth / newHeight; resizeHandleCoords.X = originalRectangle.Left + newSize.Width;
flippedRatioSign = Math.Sign(newRatio) * Math.Sign(originalRatio); resizeHandleCoords.Y = originalRectangle.Bottom - newSize.Height;
if (Math.Abs(newRatio) > Math.Abs(originalRatio)) {
// scaled rectangle (ratio) would be wider than original
// keep height and tweak width to maintain aspect ratio
float tweakedWidth = newHeight * originalRatio * flippedRatioSign;
resizeHandleCoords.X = originalRectangle.Left + tweakedWidth;
}
else if (Math.Abs(newRatio) < Math.Abs(originalRatio)) {
// scaled rectangle (ratio) would be taller than original
// keep width and tweak height to maintain aspect ratio
float tweakedHeight = newWidth / originalRatio * flippedRatioSign;
resizeHandleCoords.Y = originalRectangle.Bottom - tweakedHeight;
}
break; break;
case Positions.BottomLeft: case Positions.BottomLeft:
newWidth = originalRectangle.Right - resizeHandleCoords.X; selectedRectangle = new SizeF(originalRectangle.Right - resizeHandleCoords.X, resizeHandleCoords.Y - originalRectangle.Top);
newHeight = resizeHandleCoords.Y - originalRectangle.Top; newSize = getNewSizeForRationalScale(originalRectangle.Size, selectedRectangle);
newRatio = newWidth / newHeight; resizeHandleCoords.X = originalRectangle.Right - newSize.Width;
flippedRatioSign = Math.Sign(newRatio) * Math.Sign(originalRatio); resizeHandleCoords.Y = originalRectangle.Top + newSize.Height;
if (Math.Abs(newRatio) > Math.Abs(originalRatio)) {
// scaled rectangle (ratio) would be wider than original
// keep height and tweak width to maintain aspect ratio
float tweakedWidth = newHeight * originalRatio * flippedRatioSign;
resizeHandleCoords.X = originalRectangle.Right - tweakedWidth;
}
else if (Math.Abs(newRatio) < Math.Abs(originalRatio)) {
// scaled rectangle (ratio) would be taller than original
// keep width and tweak height to maintain aspect ratio
float tweakedHeight = newWidth / originalRatio * flippedRatioSign;
resizeHandleCoords.Y = originalRectangle.Top + tweakedHeight;
}
break; break;
case Positions.BottomRight: case Positions.BottomRight:
newWidth = resizeHandleCoords.X - originalRectangle.Left; selectedRectangle = new SizeF(resizeHandleCoords.X - originalRectangle.Left, resizeHandleCoords.Y - originalRectangle.Top);
newHeight = resizeHandleCoords.Y - originalRectangle.Top; newSize = getNewSizeForRationalScale(originalRectangle.Size, selectedRectangle);
newRatio = newWidth / newHeight; resizeHandleCoords.X = originalRectangle.Left + newSize.Width;
flippedRatioSign = Math.Sign(newRatio) * Math.Sign(originalRatio); resizeHandleCoords.Y = originalRectangle.Top + newSize.Height;
if (Math.Abs(newRatio) > Math.Abs(originalRatio)) {
// scaled rectangle (ratio) would be wider than original
// keep height and tweak width to maintain aspect ratio
float tweakedWidth = newHeight * originalRatio * flippedRatioSign;
resizeHandleCoords.X = originalRectangle.Left + tweakedWidth;
}
else if (Math.Abs(newRatio) < Math.Abs(originalRatio)) {
// TODO this is the same code as else if for topleft!
// scaled rectangle (ratio) would be taller than original
// keep width and tweak height to maintain aspect ratio
float tweakedHeight = newWidth / originalRatio * flippedRatioSign;
resizeHandleCoords.Y = originalRectangle.Top + tweakedHeight;
}
break; break;
} }
} }
/// <summary>
/// For an original size, and a selected size, returns the the largest possible size that
/// * has the same aspect ratio as the original
/// * fits into selected size
/// </summary>
/// <param name="originalSize">size to be considered for keeping aspect ratio</param>
/// <param name="selectedSize">selection size (i.e. the size we'd produce if we wouldn't keep aspect ratio)</param>
/// <returns></returns>
private static SizeF getNewSizeForRationalScale(SizeF originalSize, SizeF selectedSize)
{
SizeF newSize = selectedSize;
float originalRatio = originalSize.Width / originalSize.Height;
float selectedRatio = selectedSize.Width / selectedSize.Height;
// will fix orientation if the scaling causes size to be flipped in any direction
int flippedRatioSign = Math.Sign(selectedRatio) * Math.Sign(originalRatio);
if (Math.Abs(selectedRatio) > Math.Abs(originalRatio))
{
// scaled rectangle (ratio) would be wider than original
// keep height and tweak width to maintain aspect ratio
newSize.Width = selectedSize.Height * originalRatio * flippedRatioSign;
}
else if (Math.Abs(selectedRatio) < Math.Abs(originalRatio))
{
// scaled rectangle (ratio) would be taller than original
// keep width and tweak height to maintain aspect ratio
newSize.Height = selectedSize.Width / originalRatio * flippedRatioSign;
}
return newSize;
}
public static void Scale(Rectangle boundsBeforeResize, int cursorX, int cursorY, ref RectangleF boundsAfterResize) { public static void Scale(Rectangle boundsBeforeResize, int cursorX, int cursorY, ref RectangleF boundsAfterResize) {
Scale(boundsBeforeResize, cursorX, cursorY, ref boundsAfterResize, null); Scale(boundsBeforeResize, cursorX, cursorY, ref boundsAfterResize, null);
} }