From 2ed1961c3f22ed483b224bee8f44083c543e17df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=A4rkl?= Date: Fri, 1 Nov 2019 12:53:06 +0100 Subject: [PATCH] Add more Empty Infos on Android --- .../com/metallic/chiaki/main/MainActivity.kt | 16 +++++++++ .../SettingsRegisteredHostsFragment.kt | 1 + .../app/src/main/res/layout/activity_main.xml | 34 +++++++++++++++++++ .../fragment_settings_registered_hosts.xml | 30 ++++++++++++++++ android/app/src/main/res/values/strings.xml | 3 ++ 5 files changed, 84 insertions(+) diff --git a/android/app/src/main/java/com/metallic/chiaki/main/MainActivity.kt b/android/app/src/main/java/com/metallic/chiaki/main/MainActivity.kt index 7904b46..9e85b91 100644 --- a/android/app/src/main/java/com/metallic/chiaki/main/MainActivity.kt +++ b/android/app/src/main/java/com/metallic/chiaki/main/MainActivity.kt @@ -22,6 +22,7 @@ import android.content.Intent import android.os.Bundle import android.view.Menu import android.view.MenuItem +import android.view.View import androidx.appcompat.app.AppCompatActivity import androidx.lifecycle.Observer import androidx.lifecycle.ViewModelProviders @@ -78,13 +79,28 @@ class MainActivity : AppCompatActivity() recyclerViewAdapter.hosts = it if(top) hostsRecyclerView.scrollToPosition(0) + updateEmptyInfo() }) viewModel.discoveryActive.observe(this, Observer { active -> discoveryMenuItem?.let { updateDiscoveryMenuItem(it, active) } + updateEmptyInfo() }) } + private fun updateEmptyInfo() + { + if(viewModel.displayHosts.value?.isEmpty() ?: true) + { + emptyInfoLayout.visibility = View.VISIBLE + val discoveryActive = viewModel.discoveryActive.value ?: false + emptyInfoImageView.setImageResource(if(discoveryActive) R.drawable.ic_discover_on else R.drawable.ic_discover_off) + emptyInfoTextView.setText(if(discoveryActive) R.string.display_hosts_empty_discovery_on_info else R.string.display_hosts_empty_discovery_off_info) + } + else + emptyInfoLayout.visibility = View.GONE + } + private fun expandFloatingActionButton(expand: Boolean) { floatingActionButton.isExpanded = expand diff --git a/android/app/src/main/java/com/metallic/chiaki/settings/SettingsRegisteredHostsFragment.kt b/android/app/src/main/java/com/metallic/chiaki/settings/SettingsRegisteredHostsFragment.kt index 0306b84..517f08e 100644 --- a/android/app/src/main/java/com/metallic/chiaki/settings/SettingsRegisteredHostsFragment.kt +++ b/android/app/src/main/java/com/metallic/chiaki/settings/SettingsRegisteredHostsFragment.kt @@ -75,6 +75,7 @@ class SettingsRegisteredHostsFragment: AppCompatDialogFragment(), TitleFragment ItemTouchHelper(itemTouchSwipeCallback).attachToRecyclerView(hostsRecyclerView) viewModel.registeredHosts.observe(this, Observer { adapter.hosts = it + emptyInfoGroup.visibility = if(it.isEmpty()) View.VISIBLE else View.GONE }) floatingActionButton.setOnClickListener { diff --git a/android/app/src/main/res/layout/activity_main.xml b/android/app/src/main/res/layout/activity_main.xml index d7f88d4..e16f368 100644 --- a/android/app/src/main/res/layout/activity_main.xml +++ b/android/app/src/main/res/layout/activity_main.xml @@ -16,6 +16,40 @@ android:clipChildren="false" app:layout_behavior="@string/appbar_scrolling_view_behavior"/> + + + + + + + + + + + + diff --git a/android/app/src/main/res/values/strings.xml b/android/app/src/main/res/values/strings.xml index 963a2d5..fb89b5c 100644 --- a/android/app/src/main/res/values/strings.xml +++ b/android/app/src/main/res/values/strings.xml @@ -75,6 +75,9 @@ Delete Edit No Session Logs recorded. + No Consoles registered. + No consoles added yet.\nEnable Discovery to automatically find consoles on your local network. + No consoles added or discovered. discovery_enabled