mirror of
https://github.com/bettercap/bettercap
synced 2025-07-16 10:03:39 -07:00
started the long adventure of unit testing bettercap
This commit is contained in:
evilsocket
parent
889ef0cbe0
commit
cd6fcbf4be
2 changed files with 280 additions and 14 deletions
21
core/core.go
21
core/core.go
|
|
@ -72,18 +72,11 @@ func ExecSilent(executable string, args []string) (string, error) {
|
|||
}
|
||||
|
||||
func Exec(executable string, args []string) (string, error) {
|
||||
path, err := exec.LookPath(executable)
|
||||
out, err := ExecSilent(executable, args)
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
|
||||
raw, err := exec.Command(path, args...).CombinedOutput()
|
||||
if err != nil {
|
||||
fmt.Printf("ERROR: path=%s args=%s err=%s out='%s'\n", path, args, err, raw)
|
||||
return "", err
|
||||
} else {
|
||||
return Trim(string(raw)), nil
|
||||
fmt.Printf("ERROR for '%s %s': %s\n", executable, args, err)
|
||||
}
|
||||
return out, err
|
||||
}
|
||||
|
||||
func Exists(path string) bool {
|
||||
|
|
@ -97,12 +90,12 @@ func ExpandPath(path string) (string, error) {
|
|||
// Check if path is empty
|
||||
if path != "" {
|
||||
if strings.HasPrefix(path, "~") {
|
||||
usr, err := user.Current()
|
||||
if err != nil {
|
||||
if usr, err := user.Current(); err != nil {
|
||||
return "", err
|
||||
} else {
|
||||
// Replace only the first occurrence of ~
|
||||
path = strings.Replace(path, "~", usr.HomeDir, 1)
|
||||
}
|
||||
// Replace only the first occurrence of ~
|
||||
path = strings.Replace(path, "~", usr.HomeDir, 1)
|
||||
}
|
||||
return filepath.Abs(path)
|
||||
}
|
||||
|
|
|
|||
273
core/core_test.go
Normal file
273
core/core_test.go
Normal file
|
|
@ -0,0 +1,273 @@
|
|||
package core
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"io"
|
||||
"os"
|
||||
"os/user"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestCoreTrim(t *testing.T) {
|
||||
var units = []struct {
|
||||
from string
|
||||
to string
|
||||
}{
|
||||
{"\t ", ""},
|
||||
{" ", ""},
|
||||
{" hello world", "hello world"},
|
||||
{"hello world ", "hello world"},
|
||||
{" hello world\t", "hello world"},
|
||||
}
|
||||
|
||||
for _, u := range units {
|
||||
got := Trim(u.from)
|
||||
if got != u.to {
|
||||
t.Fatalf("expected '%s', got '%s'", u.to, got)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestCoreTrimRight(t *testing.T) {
|
||||
var units = []struct {
|
||||
from string
|
||||
to string
|
||||
}{
|
||||
{"\t ", ""},
|
||||
{" ", ""},
|
||||
{" hello world", " hello world"},
|
||||
{"hello world ", "hello world"},
|
||||
{" hello world\t", " hello world"},
|
||||
}
|
||||
|
||||
for _, u := range units {
|
||||
got := TrimRight(u.from)
|
||||
if got != u.to {
|
||||
t.Fatalf("expected '%s', got '%s'", u.to, got)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func hasInt(a []int, v int) bool {
|
||||
for _, n := range a {
|
||||
if n == v {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
func sameInts(a []int, b []int, ordered bool) bool {
|
||||
if len(a) != len(b) {
|
||||
return false
|
||||
}
|
||||
|
||||
if ordered {
|
||||
for i, v := range a {
|
||||
if v != b[i] {
|
||||
return false
|
||||
}
|
||||
}
|
||||
} else {
|
||||
for _, v := range a {
|
||||
if !hasInt(b, v) {
|
||||
return false
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return true
|
||||
}
|
||||
|
||||
func TestCoreUniqueIntsUnsorted(t *testing.T) {
|
||||
var units = []struct {
|
||||
from []int
|
||||
to []int
|
||||
}{
|
||||
{[]int{}, []int{}},
|
||||
{[]int{1, 1, 1, 1, 1}, []int{1}},
|
||||
{[]int{1, 2, 1, 2, 3, 4}, []int{1, 2, 3, 4}},
|
||||
{[]int{4, 3, 4, 3, 2, 2}, []int{4, 3, 2}},
|
||||
{[]int{8, 3, 8, 4, 6, 1}, []int{8, 3, 4, 6, 1}},
|
||||
}
|
||||
|
||||
for _, u := range units {
|
||||
got := UniqueInts(u.from, false)
|
||||
if !sameInts(got, u.to, false) {
|
||||
t.Fatalf("expected '%v', got '%v'", u.to, got)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestCoreUniqueIntsSorted(t *testing.T) {
|
||||
var units = []struct {
|
||||
from []int
|
||||
to []int
|
||||
}{
|
||||
{[]int{}, []int{}},
|
||||
{[]int{1, 1, 1, 1, 1}, []int{1}},
|
||||
{[]int{1, 2, 1, 2, 3, 4}, []int{1, 2, 3, 4}},
|
||||
{[]int{4, 3, 4, 3, 2, 2}, []int{2, 3, 4}},
|
||||
{[]int{8, 3, 8, 4, 6, 1}, []int{1, 3, 4, 6, 8}},
|
||||
}
|
||||
|
||||
for _, u := range units {
|
||||
got := UniqueInts(u.from, true)
|
||||
if !sameInts(got, u.to, true) {
|
||||
t.Fatalf("expected '%v', got '%v'", u.to, got)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func sameStrings(a []string, b []string) bool {
|
||||
if len(a) != len(b) {
|
||||
return false
|
||||
}
|
||||
for i, v := range a {
|
||||
if v != b[i] {
|
||||
return false
|
||||
}
|
||||
}
|
||||
return true
|
||||
}
|
||||
|
||||
func TestCoreSepSplitAndCommaSplit(t *testing.T) {
|
||||
var units = []struct {
|
||||
from string
|
||||
to []string
|
||||
}{
|
||||
{"foo", []string{"foo"}},
|
||||
{"foo#bar", []string{"foo#bar"}},
|
||||
{"foo,bar", []string{"foo", "bar"}},
|
||||
{"foo,bar,", []string{"foo", "bar"}},
|
||||
{"foo,bar,", []string{"foo", "bar"}},
|
||||
{"foo,,bar,", []string{"foo", "bar"}},
|
||||
{"foo,,bar,,,,", []string{"foo", "bar"}},
|
||||
{"foo,bar@wut,.ok", []string{"foo", "bar@wut", ".ok"}},
|
||||
}
|
||||
|
||||
for _, u := range units {
|
||||
if got := SepSplit(u.from, ","); !sameStrings(got, u.to) {
|
||||
t.Fatalf("expected '%v', got '%v'", u.to, got)
|
||||
} else if got = CommaSplit(u.from); !sameStrings(got, u.to) {
|
||||
t.Fatalf("expected '%v', got '%v'", u.to, got)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestCoreExec(t *testing.T) {
|
||||
var units = []struct {
|
||||
exec string
|
||||
args []string
|
||||
out string
|
||||
err string
|
||||
stdout string
|
||||
}{
|
||||
{"foo", []string{}, "", `exec: "foo": executable file not found in $PATH`, `ERROR for 'foo []': exec: "foo": executable file not found in $PATH`},
|
||||
{"ps", []string{"-someinvalidflag"}, "", "exit status 1", "ERROR for 'ps [-someinvalidflag]': exit status 1"},
|
||||
{"true", []string{}, "", "", ""},
|
||||
{"head", []string{"/proc/self/comm"}, "head", "", ""},
|
||||
}
|
||||
|
||||
for _, u := range units {
|
||||
var buf bytes.Buffer
|
||||
|
||||
oldStdout := os.Stdout
|
||||
r, w, _ := os.Pipe()
|
||||
os.Stdout = w
|
||||
|
||||
gotOut, gotErr := ExecSilent(u.exec, u.args)
|
||||
w.Close()
|
||||
io.Copy(&buf, r)
|
||||
os.Stdout = oldStdout
|
||||
|
||||
gotStdout := Trim(buf.String())
|
||||
if gotOut != u.out {
|
||||
t.Fatalf("expected output '%s', got '%s'", u.out, gotOut)
|
||||
} else if u.err == "" && gotErr != nil {
|
||||
t.Fatalf("expected no error, got '%s'", gotErr)
|
||||
} else if u.err != "" && gotErr == nil {
|
||||
t.Fatalf("expected error '%s', got none", u.err)
|
||||
} else if u.err != "" && gotErr != nil && gotErr.Error() != u.err {
|
||||
t.Fatalf("expected error '%s', got '%s'", u.err, gotErr)
|
||||
} else if gotStdout != "" {
|
||||
t.Fatalf("expected empty stdout, got '%s'", gotStdout)
|
||||
}
|
||||
}
|
||||
|
||||
for _, u := range units {
|
||||
var buf bytes.Buffer
|
||||
|
||||
oldStdout := os.Stdout
|
||||
r, w, _ := os.Pipe()
|
||||
os.Stdout = w
|
||||
|
||||
gotOut, gotErr := Exec(u.exec, u.args)
|
||||
w.Close()
|
||||
io.Copy(&buf, r)
|
||||
os.Stdout = oldStdout
|
||||
|
||||
gotStdout := Trim(buf.String())
|
||||
if gotOut != u.out {
|
||||
t.Fatalf("expected output '%s', got '%s'", u.out, gotOut)
|
||||
} else if u.err == "" && gotErr != nil {
|
||||
t.Fatalf("expected no error, got '%s'", gotErr)
|
||||
} else if u.err != "" && gotErr == nil {
|
||||
t.Fatalf("expected error '%s', got none", u.err)
|
||||
} else if u.err != "" && gotErr != nil && gotErr.Error() != u.err {
|
||||
t.Fatalf("expected error '%s', got '%s'", u.err, gotErr)
|
||||
} else if gotStdout != u.stdout {
|
||||
t.Fatalf("expected stdout '%s', got '%s'", u.stdout, gotStdout)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestCoreExists(t *testing.T) {
|
||||
var units = []struct {
|
||||
what string
|
||||
exists bool
|
||||
}{
|
||||
{".", true},
|
||||
{"/", true},
|
||||
{"wuuut", false},
|
||||
{"/wuuu.t", false},
|
||||
{os.Args[0], true},
|
||||
}
|
||||
|
||||
for _, u := range units {
|
||||
got := Exists(u.what)
|
||||
if got != u.exists {
|
||||
t.Fatalf("expected '%v', got '%v'", u.exists, got)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestCoreExpandPath(t *testing.T) {
|
||||
base, _ := filepath.Abs(".")
|
||||
usr, _ := user.Current()
|
||||
|
||||
var units = []struct {
|
||||
from string
|
||||
to string
|
||||
err string
|
||||
}{
|
||||
{"", "", ""},
|
||||
{"/lulz", "/lulz", ""},
|
||||
{".", base, ""},
|
||||
{"~", usr.HomeDir, ""},
|
||||
}
|
||||
|
||||
for _, u := range units {
|
||||
gotPath, gotErr := ExpandPath(u.from)
|
||||
if gotPath != u.to {
|
||||
t.Fatalf("expected path '%s', got '%s'", u.to, gotPath)
|
||||
} else if u.err == "" && gotErr != nil {
|
||||
t.Fatalf("expected no error, got '%v'", gotErr)
|
||||
} else if u.err != "" && gotErr == nil {
|
||||
t.Fatalf("expected error '%s', got none", u.err)
|
||||
} else if u.err != "" && gotErr != nil && gotErr.Error() != u.err {
|
||||
t.Fatalf("expected error '%s', got '%s'", u.err, gotErr.Error())
|
||||
}
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue