github/bettercap
1
0
Fork 0
mirror of https://github.com/bettercap/bettercap synced 2025-08-19 21:13:18 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Catch RR nil value, improve debug logs readability.

Browse source
This commit is contained in:
buffermet 2024-10-09 20:07:22 +02:00
commit c5d93825bd
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
modules/dns_proxy/dns_proxy_base_filters.go
View file

@ -17,7 +17,9 @@ func questionsToStrings(qs []dns.Question) []string {
func recordsToStrings(rrs []dns.RR) []string { func recordsToStrings(rrs []dns.RR) []string {
records := []string{} records := []string{}
for _, rr := range rrs { for _, rr := range rrs {
records = append(records, tabsToSpaces(rr.String())) if rr != nil {
records = append(records, tabsToSpaces(rr.String()))
}
} }
return records return records
} }
@ -57,7 +59,7 @@ func (p *DNSProxy) logResponseAction(m *dns.Msg, clientIP string) {
} }
func (p *DNSProxy) onRequestFilter(query *dns.Msg, clientIP string) (req, res *dns.Msg) { func (p *DNSProxy) onRequestFilter(query *dns.Msg, clientIP string) (req, res *dns.Msg) {
p.Debug("< %s %s", p.Debug("< %s q[%s]",
clientIP, clientIP,
strings.Join(questionsToStrings(query.Question), ",")) strings.Join(questionsToStrings(query.Question), ","))
@ -89,7 +91,7 @@ func (p *DNSProxy) onResponseFilter(req, res *dns.Msg, clientIP string) *dns.Msg
return nil return nil
} }
p.Debug("> %s %s [%s] [%s] [%s]", p.Debug("> %s q[%s] a[%s] e[%s] n[%s]",
clientIP, clientIP,
strings.Join(questionsToStrings(res.Question), ","), strings.Join(questionsToStrings(res.Question), ","),
strings.Join(recordsToStrings(res.Answer), ","), strings.Join(recordsToStrings(res.Answer), ","),