From c49a57893af7d4ce29242bcf5eafb86c9d4d3013 Mon Sep 17 00:00:00 2001 From: evilsocket Date: Wed, 13 Mar 2019 13:35:08 +0100 Subject: [PATCH] fix: made arp.spoof debug logs less verbose when mac addresses can't be resolved (ref #483) --- modules/arp_spoof/arp_spoof.go | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/modules/arp_spoof/arp_spoof.go b/modules/arp_spoof/arp_spoof.go index 100e0f44..8b2a9b1f 100644 --- a/modules/arp_spoof/arp_spoof.go +++ b/modules/arp_spoof/arp_spoof.go @@ -218,20 +218,18 @@ func (mod *ArpSpoofer) getTargets(probe bool) map[string]net.HardwareAddr { continue } // do we have this ip mac address? - if hw, err := mod.Session.FindMAC(ip, probe); err != nil { - mod.Debug("could not find hardware address for %s", ip.String()) - } else { + if hw, err := mod.Session.FindMAC(ip, probe); err == nil { targets[ip.String()] = hw } } // add targets specified by MAC address for _, hw := range mod.macs { - if ip, err := network.ArpInverseLookup(mod.Session.Interface.Name(), hw.String(), false); err != nil { - mod.Warning("could not find IP address for %s", hw.String()) - } else if mod.Session.Skip(net.ParseIP(ip)) { - mod.Debug("skipping address %s from arp spoofing.", ip) - } else { - targets[ip] = hw + if ip, err := network.ArpInverseLookup(mod.Session.Interface.Name(), hw.String(), false); err == nil { + if mod.Session.Skip(net.ParseIP(ip)) { + mod.Debug("skipping address %s from arp spoofing.", ip) + } else { + targets[ip] = hw + } } }