github/bettercap
1
0
Fork 0
mirror of https://github.com/bettercap/bettercap synced 2025-08-14 02:36:57 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: fixed events buffering, now no event is lost with multiple listeners (fixes #266)

Browse source
This commit is contained in:
evilsocket 2018-05-12 12:16:15 +02:00
commit 9f0b4a9502
No known key found for this signature in database
GPG key ID: 1564D7F30393A456
3 changed files with 25 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

24
session/events.go
View file

@ -62,6 +62,19 @@ func (p *EventPool) Listen() <-chan Event {
return l
}
func (p *EventPool) Unlisten(listener <-chan Event) {
p.Lock()
defer p.Unlock()
for i, l := range p.listeners {
if l == listener {
close(l)
p.listeners = append(p.listeners[:i], p.listeners[i+1:]...)
return
}
}
}
func (p *EventPool) SetSilent(s bool) {
p.Lock()
defer p.Unlock()
@ -83,16 +96,7 @@ func (p *EventPool) Add(tag string, data interface{}) {
// broadcast the event to every listener
for _, l := range p.listeners {
select {
case l <- e:
// NOTE: Without this 'default', errors in sending the event
// to the listener would not empty the channel, therefore
// all operations would be stuck at some point (after the first
// event if not buffered or after the first N events if buffered)
//
// See https://github.com/bettercap/bettercap/issues/198
default:
}
l <- e
}
}