github/bettercap
1
0
Fork 0
mirror of https://github.com/bettercap/bettercap synced 2025-08-20 21:43:18 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #669 from coderobe/patch-setrfmon

Browse source 
modules/wifi: Fix handle activation when monitor device is already set up
This commit is contained in:
Simone Margaritelli 2020-01-17 11:48:01 +01:00 • committed by GitHub
commit 9bf0139181
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
modules/wifi/wifi.go
View file

@ -481,6 +481,7 @@ func (mod *WiFiModule) Configure() error {
} }
} }
setRFMonMaybeFatal := false
for retry := 0; ; retry++ { for retry := 0; ; retry++ {
ihandle, err := pcap.NewInactiveHandle(ifName) ihandle, err := pcap.NewInactiveHandle(ifName)
if err != nil { if err != nil {
@ -488,9 +489,18 @@ func (mod *WiFiModule) Configure() error {
} }
defer ihandle.CleanUp() defer ihandle.CleanUp()
/*
* Calling SetRFMon is fatal when the interface is already in monitor mode.
* gopacket has no GetRFMon analogue to SetRFMon with which we could check this, however ...
*/
if !setRFMonMaybeFatal {
if err = ihandle.SetRFMon(true); err != nil { if err = ihandle.SetRFMon(true); err != nil {
return fmt.Errorf("error while setting interface %s in monitor mode: %s", tui.Bold(ifName), err) return fmt.Errorf("error while setting interface %s in monitor mode: %s", tui.Bold(ifName), err)
} else if err = ihandle.SetSnapLen(65536); err != nil { }
} else {
mod.Debug("SetRFMon on interface %s might be fatal, skipping this time", tui.Bold(ifName))
}
if err = ihandle.SetSnapLen(65536); err != nil {
return fmt.Errorf("error while settng snapshot length: %s", err) return fmt.Errorf("error while settng snapshot length: %s", err)
} }
/* /*
@ -508,7 +518,13 @@ func (mod *WiFiModule) Configure() error {
} }
continue continue
} }
if setRFMonMaybeFatal {
return fmt.Errorf("error while activating handle: %s", err) return fmt.Errorf("error while activating handle: %s", err)
} else {
mod.Warning("error while activating handle: %s, %s", err, tui.Bold("interface might already be monitoring. retrying!"))
setRFMonMaybeFatal = true
continue
}
} }
break break