From 5e180e97c54a970af8e588dee728e3d5d2ba4745 Mon Sep 17 00:00:00 2001
From: dadav <33197631+dadav@users.noreply.github.com>
Date: Mon, 9 Dec 2019 19:36:26 +0100
Subject: [PATCH] Switch to ip command

---
 modules/mac_changer.go             | 129 +++++++++++++++++++++++++++++
 modules/mac_changer/mac_changer.go |  12 +--
 2 files changed, 136 insertions(+), 5 deletions(-)
 create mode 100644 modules/mac_changer.go

diff --git a/modules/mac_changer.go b/modules/mac_changer.go
new file mode 100644
index 00000000..3f64b2e8
--- /dev/null
+++ b/modules/mac_changer.go
@@ -0,0 +1,129 @@
+package modules
+
+import (
+	"fmt"
+	"net"
+	"runtime"
+	"strings"
+
+	"github.com/bettercap/bettercap/core"
+	"github.com/bettercap/bettercap/log"
+	"github.com/bettercap/bettercap/network"
+	"github.com/bettercap/bettercap/session"
+
+	"github.com/evilsocket/islazy/tui"
+)
+
+type MacChanger struct {
+	session.SessionModule
+	iface       string
+	originalMac net.HardwareAddr
+	fakeMac     net.HardwareAddr
+}
+
+func NewMacChanger(s *session.Session) *MacChanger {
+	mc := &MacChanger{
+		SessionModule: session.NewSessionModule("mac.changer", s),
+	}
+
+	mc.AddParam(session.NewStringParameter("mac.changer.iface",
+		session.ParamIfaceName,
+		"",
+		"Name of the interface to use."))
+
+	mc.AddParam(session.NewStringParameter("mac.changer.address",
+		session.ParamRandomMAC,
+		"[a-fA-F0-9]{2}:[a-fA-F0-9]{2}:[a-fA-F0-9]{2}:[a-fA-F0-9]{2}:[a-fA-F0-9]{2}:[a-fA-F0-9]{2}",
+		"Hardware address to apply to the interface."))
+
+	mc.AddHandler(session.NewModuleHandler("mac.changer on", "",
+		"Start mac changer module.",
+		func(args []string) error {
+			return mc.Start()
+		}))
+
+	mc.AddHandler(session.NewModuleHandler("mac.changer off", "",
+		"Stop mac changer module and restore original mac address.",
+		func(args []string) error {
+			return mc.Stop()
+		}))
+
+	return mc
+}
+
+func (mc *MacChanger) Name() string {
+	return "mac.changer"
+}
+
+func (mc *MacChanger) Description() string {
+	return "Change active interface mac address."
+}
+
+func (mc *MacChanger) Author() string {
+	return "Simone Margaritelli <evilsocket@protonmail.com>"
+}
+
+func (mc *MacChanger) Configure() (err error) {
+	var changeTo string
+
+	if err, mc.iface = mc.StringParam("mac.changer.iface"); err != nil {
+		return err
+	} else if err, changeTo = mc.StringParam("mac.changer.address"); err != nil {
+		return err
+	}
+
+	changeTo = network.NormalizeMac(changeTo)
+	if mc.fakeMac, err = net.ParseMAC(changeTo); err != nil {
+		return err
+	}
+
+	mc.originalMac = mc.Session.Interface.HW
+
+	return nil
+}
+
+func (mc *MacChanger) setMac(mac net.HardwareAddr) error {
+	var args []string
+
+	os := runtime.GOOS
+	cmd := "ip"
+	if strings.Contains(os, "bsd") || os == "darwin" {
+		cmd = "ifconfig"
+		args = []string{mc.iface, "ether", mac.String()}
+	} else if os == "linux" || os == "android" {
+		args = []string{"link", "set", mc.iface, "address", mac.String()}
+	} else {
+		return fmt.Errorf("OS %s is not supported by mac.changer module.", os)
+	}
+
+	_, err := core.Exec(cmd, args)
+	if err == nil {
+		mc.Session.Interface.HW = mac
+	}
+
+	return err
+}
+
+func (mc *MacChanger) Start() error {
+	if mc.Running() {
+		return session.ErrAlreadyStarted
+	} else if err := mc.Configure(); err != nil {
+		return err
+	} else if err := mc.setMac(mc.fakeMac); err != nil {
+		return err
+	}
+
+	return mc.SetRunning(true, func() {
+		log.Info("Interface mac address set to %s", tui.Bold(mc.fakeMac.String()))
+	})
+}
+
+func (mc *MacChanger) Stop() error {
+	return mc.SetRunning(false, func() {
+		if err := mc.setMac(mc.originalMac); err == nil {
+			log.Info("Interface mac address restored to %s", tui.Bold(mc.originalMac.String()))
+		} else {
+			log.Error("Error while restoring mac address: %s", err)
+		}
+	})
+}
diff --git a/modules/mac_changer/mac_changer.go b/modules/mac_changer/mac_changer.go
index a991cfb1..6686018e 100644
--- a/modules/mac_changer/mac_changer.go
+++ b/modules/mac_changer/mac_changer.go
@@ -81,21 +81,23 @@ func (mod *MacChanger) Configure() (err error) {
 	return nil
 }
 
-func (mod *MacChanger) setMac(mac net.HardwareAddr) error {
+func (mc *MacChanger) setMac(mac net.HardwareAddr) error {
 	var args []string
 
 	os := runtime.GOOS
+	cmd := "ip"
 	if strings.Contains(os, "bsd") || os == "darwin" {
-		args = []string{mod.iface, "ether", mac.String()}
+		cmd = "ifconfig"
+		args = []string{mc.iface, "ether", mac.String()}
 	} else if os == "linux" || os == "android" {
-		args = []string{mod.iface, "hw", "ether", mac.String()}
+		args = []string{"link", "set", mc.iface, "address", mac.String()}
 	} else {
 		return fmt.Errorf("OS %s is not supported by mac.changer module.", os)
 	}
 
-	_, err := core.Exec("ifconfig", args)
+	_, err := core.Exec(cmd, args)
 	if err == nil {
-		mod.Session.Interface.HW = mac
+		mc.Session.Interface.HW = mac
 	}
 
 	return err