Revert "Minor refactors using golint"

This commit is contained in:
Simone Margaritelli 2018-05-03 12:31:42 +02:00 committed by GitHub
parent 9196be7a8b
commit 5328ced392
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 101 additions and 70 deletions

View file

@ -62,12 +62,13 @@ func (m SessionModule) ListParam(name string) (err error, values []string) {
list := ""
if err, list = m.StringParam(name); err != nil {
return
}
parts := strings.Split(list, ",")
for _, part := range parts {
part = core.Trim(part)
if part != "" {
values = append(values, part)
} else {
parts := strings.Split(list, ",")
for _, part := range parts {
part = core.Trim(part)
if part != "" {
values = append(values, part)
}
}
}
return
@ -77,27 +78,33 @@ func (m SessionModule) StringParam(name string) (error, string) {
if p, found := m.params[name]; found {
if err, v := p.Get(m.Session); err != nil {
return err, ""
} else {
return nil, v.(string)
}
return nil, v.(string)
} else {
return fmt.Errorf("Parameter %s does not exist.", name), ""
}
return fmt.Errorf("Parameter %s does not exist.", name), ""
}
func (m SessionModule) IntParam(name string) (error, int) {
if p, found := m.params[name]; found {
if err, v := p.Get(m.Session); err != nil {
return err, 0
} else {
return nil, v.(int)
}
return nil, v.(int)
} else {
return fmt.Errorf("Parameter %s does not exist.", name), 0
}
return fmt.Errorf("Parameter %s does not exist.", name), 0
}
func (m SessionModule) BoolParam(name string) (error, bool) {
if err, v := m.params[name].Get(m.Session); err != nil {
return err, false
} else {
return nil, v.(bool)
}
return nil, v.(bool)
}
func (m *SessionModule) AddHandler(h ModuleHandler) {
@ -120,8 +127,9 @@ func (m *SessionModule) SetRunning(running bool, cb func()) error {
if running == m.Running() {
if m.Started {
return ErrAlreadyStarted
} else {
return ErrAlreadyStopped
}
return ErrAlreadyStopped
}
m.StatusLock.Lock()