github/bettercap
1
0
Fork 0
mirror of https://github.com/bettercap/bettercap synced 2025-08-22 14:24:38 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix: Content-Length=0 when res.ReadBody() not used

Browse source 
+ Testcase:
https://github.com/b3tt3rfun/caplets-bugs/blob/master/res-header-bug.cap
https://github.com/b3tt3rfun/caplets-bugs/blob/master/res-header-bug.js
+ Explanation: This testcase only tries to modify a response header and res.ReadBody() is never used. It produces len(jres.Body) = 0, the response header is modified but Content-Length is zero.
+ The fix is to internally trigger ReadBody() when jsres.Body length is null.
+ Result before commit:
[01:55:25] [http.proxy.spoofed-response] {http.proxy.spoofed-response 2018-03-17 ... {192.168.1.64 GET www.ufl.edu / 0}}
+ Result after commit:
[01:56:35] [http.proxy.spoofed-response] {http.proxy.spoofed-response 2018-03-17 ... {192.168.1.64 GET www.ufl.edu / 29982}}
This commit is contained in:
b3tt3rfun 2018-03-17 03:24:35 +01:00 • committed by GitHub
commit 31b3f04e60
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
modules/http_proxy_base_filters.go
View file

@ -83,6 +83,9 @@ func (p *HTTPProxy) logRequestAction(req *http.Request, jsreq *JSRequest) {
}
func (p *HTTPProxy) logResponseAction(req *http.Request, jsres *JSResponse) {
if len(jsres.Body) == 0 {
jsres.ReadBody()
}
p.sess.Events.Add(p.Name+".spoofed-response", struct {
To string
Method string