github/bettercap
1
0
Fork 0
mirror of https://github.com/bettercap/bettercap synced 2025-08-19 13:09:49 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

wifi.go: dont claim read lock until it is needed

Browse source
This commit is contained in:
bonedaddy 2020-12-23 13:22:48 -08:00
commit 10817d574c
No known key found for this signature in database
GPG key ID: 5386234333106B29
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
network/wifi.go
View file

@ -218,9 +218,6 @@ func (w *WiFi) NumHandshakes() int {
} }
func (w *WiFi) SaveHandshakesTo(fileName string, linkType layers.LinkType) error { func (w *WiFi) SaveHandshakesTo(fileName string, linkType layers.LinkType) error {
w.RLock()
defer w.RUnlock()
// check if folder exists first // check if folder exists first
dirName := filepath.Dir(fileName) dirName := filepath.Dir(fileName)
if _, err := os.Stat(dirName); err != nil { if _, err := os.Stat(dirName); err != nil {
@ -244,6 +241,9 @@ func (w *WiFi) SaveHandshakesTo(fileName string, linkType layers.LinkType) error
} }
} }
w.RLock()
defer w.RUnlock()
for _, ap := range w.aps { for _, ap := range w.aps {
for _, station := range ap.Clients() { for _, station := range ap.Clients() {
// if half (which includes also complete) or has pmkid // if half (which includes also complete) or has pmkid