github/bettercap
1
0
Fork 0
mirror of https://github.com/bettercap/bettercap synced 2025-08-14 10:46:57 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Kepp sync.WorkerGroup.Add() outside of goroutine

Browse source 
The workergroup should be added before starting the worker.
The worker routine itself should not start the worker. It causes race condition.
This commit is contained in:
Hasibul Hasan Anik 2020-03-05 12:58:22 +06:00
commit 050bd28511
3 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
modules/syn_scan/syn_scan.go
View file

@ -227,8 +227,8 @@ func (mod *SynScanner) synScan() error {
mod.State.Store("progress", 0.0)
// start the collector
mod.waitGroup.Add(1)
go func() {
mod.waitGroup.Add(1)
defer mod.waitGroup.Done()
for packet := range mod.packets {

3
modules/wifi/wifi_assoc.go
View file

@ -88,9 +88,8 @@ func (mod *WiFiModule) startAssoc(to net.HardwareAddr) error {
}
return fmt.Errorf("%s is an unknown BSSID or it is in the association skip list.", to.String())
}
mod.writes.Add(1)
go func() {
mod.writes.Add(1)
defer mod.writes.Done()
// since we need to change the wifi adapter channel for each

2
modules/wifi/wifi_deauth.go
View file

@ -113,8 +113,8 @@ func (mod *WiFiModule) startDeauth(to net.HardwareAddr) error {
return fmt.Errorf("%s is an unknown BSSID, is in the deauth skip list, or doesn't have detected clients.", to.String())
}
mod.writes.Add(1)
go func() {
mod.writes.Add(1)
defer mod.writes.Done()
// since we need to change the wifi adapter channel for each