From c4b077d83b01d7830d731b7d96d43a37ef122723 Mon Sep 17 00:00:00 2001 From: Adam Bird Date: Sat, 17 Dec 2022 20:06:23 -0500 Subject: [PATCH] fix warp song hints not being set if gossip stones are turned off (#2197) --- soh/soh/Enhancements/randomizer/3drando/fill.cpp | 6 ++++++ soh/soh/Enhancements/randomizer/3drando/hints.cpp | 1 - soh/soh/Enhancements/randomizer/3drando/hints.hpp | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/soh/soh/Enhancements/randomizer/3drando/fill.cpp b/soh/soh/Enhancements/randomizer/3drando/fill.cpp index af5d54e0e..20ea61f15 100644 --- a/soh/soh/Enhancements/randomizer/3drando/fill.cpp +++ b/soh/soh/Enhancements/randomizer/3drando/fill.cpp @@ -909,6 +909,9 @@ void VanillaFill() { CreateItemOverrides(); CreateEntranceOverrides(); CreateAlwaysIncludedMessages(); + if (ShuffleWarpSongs) { + CreateWarpSongTexts(); + } } void ClearProgress() { @@ -1071,6 +1074,9 @@ int Fill() { if (ShuffleMerchants.Is(SHUFFLEMERCHANTS_HINTS)) { CreateMerchantsHints(); } + if (ShuffleWarpSongs) { + CreateWarpSongTexts(); + } return 1; } //Unsuccessful placement diff --git a/soh/soh/Enhancements/randomizer/3drando/hints.cpp b/soh/soh/Enhancements/randomizer/3drando/hints.cpp index 785ad5cc9..8516ecb76 100644 --- a/soh/soh/Enhancements/randomizer/3drando/hints.cpp +++ b/soh/soh/Enhancements/randomizer/3drando/hints.cpp @@ -779,7 +779,6 @@ void CreateAllHints() { CreateGanonText(); CreateAltarText(); - CreateWarpSongTexts(); SPDLOG_DEBUG("\nNOW CREATING HINTS\n"); const HintSetting& hintSetting = hintSettingTable[Settings::HintDistribution.Value()]; diff --git a/soh/soh/Enhancements/randomizer/3drando/hints.hpp b/soh/soh/Enhancements/randomizer/3drando/hints.hpp index 9f184f762..568708a79 100644 --- a/soh/soh/Enhancements/randomizer/3drando/hints.hpp +++ b/soh/soh/Enhancements/randomizer/3drando/hints.hpp @@ -220,6 +220,7 @@ extern std::array conditionalAlwaysHints; extern uint32_t GetHintRegionHintKey(const uint32_t area); extern void CreateAllHints(); extern void CreateMerchantsHints(); +extern void CreateWarpSongTexts(); Text& GetChildAltarText(); Text& GetAdultAltarText();