github/Shipwright
1
0
Fork 0
mirror of https://github.com/HarbourMasters/Shipwright.git synced 2025-08-19 21:03:42 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove redundent entrance logic check when adding a region to the pool. (#5413)

Browse source 
* remove redundent entrance logic check when adding a region to the pool.

* how did this trigger clang...
This commit is contained in:
Pepper0ni 2025-05-02 03:00:31 +01:00 • committed by GitHub
commit 4c9063caa7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
soh/soh/Enhancements/randomizer/3drando/fill.cpp
View file

@ -219,18 +219,18 @@ void ProcessExits(Region* region, GetAccessibleLocationsStruct& gals, Randomizer
} }
ValidateSphereZero(gals); ValidateSphereZero(gals);
} }
// process the region we just expanded to, to reduce looping
ProcessRegion(exitRegion, gals, ignore, stopOnBeatable, addToPlaythrough);
}
// If the exit is accessible and hasn't been added yet, add it to the pool // If the exit is accessible and hasn't been added yet, add it to the pool
// RANDOTODO do we want to add the region after the loop now, considering we // RANDOTODO do we want to add the region after the loop now, considering we
// are processing the new region immediately. Maybe a reverse for loop in ProcessRegion? // are processing the new region immediately. Maybe a reverse for loop in ProcessRegion?
if (!exitRegion->addedToPool && exit.ConditionsMet()) { if (!exitRegion->addedToPool) {
exitRegion->addedToPool = true; exitRegion->addedToPool = true;
gals.regionPool.push_back(exit.GetConnectedRegionKey()); gals.regionPool.push_back(exit.GetConnectedRegionKey());
} }
// process the region we just expanded to, to reduce looping
ProcessRegion(exitRegion, gals, ignore, stopOnBeatable, addToPlaythrough);
}
if (addToPlaythrough) { if (addToPlaythrough) {
// RANDOTODO Should this match the regular spheres? // RANDOTODO Should this match the regular spheres?
// Add shuffled entrances to the entrance playthrough // Add shuffled entrances to the entrance playthrough