github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-22 14:23:50 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix coverity 278907, 278906

Browse source
This commit is contained in:
iceman1001 2020-04-06 08:02:48 +02:00
commit fcf7bd24a6
1 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

18
client/cmdhfcryptorf.c
View file

@ -372,7 +372,7 @@ static int CmdHFCryptoRFELoad(const char *Cmd) {
size_t datalen = 1024; size_t datalen = 1024;
int fileNameLen = 0; int fileNameLen = 0;
char filename[FILE_PATH_SIZE] = {0x00}; char filename[FILE_PATH_SIZE] = {0x00};
bool errors = false; bool errors = false, has_filename = false;
uint8_t cmdp = 0; uint8_t cmdp = 0;
while (param_getchar(Cmd, cmdp) != 0x00 && !errors) { while (param_getchar(Cmd, cmdp) != 0x00 && !errors) {
@ -380,11 +380,12 @@ static int CmdHFCryptoRFELoad(const char *Cmd) {
case 'h' : case 'h' :
return usage_hf_cryptorf_eload(); return usage_hf_cryptorf_eload();
case 'f' : case 'f' :
fileNameLen = param_getstr(Cmd, cmdp + 1, filename, FILE_PATH_SIZE); if (param_getstr(Cmd, cmdp + 1, filename, FILE_PATH_SIZE) >= FILE_PATH_SIZE) {
if (!fileNameLen) PrintAndLogEx(FAILED, "Filename too long");
errors = true; errors = true;
if (fileNameLen > FILE_PATH_SIZE - 5) break;
fileNameLen = FILE_PATH_SIZE - 5; }
has_filename = true;
cmdp += 2; cmdp += 2;
break; break;
default : default :
@ -393,6 +394,9 @@ static int CmdHFCryptoRFELoad(const char *Cmd) {
break; break;
} }
} }
if (has_filename == false)
errors = true;
//Validations //Validations
if (errors || strlen(Cmd) == 0) return usage_hf_cryptorf_eload(); if (errors || strlen(Cmd) == 0) return usage_hf_cryptorf_eload();
@ -430,11 +434,11 @@ static int CmdHFCryptoRFELoad(const char *Cmd) {
bytes_remaining -= bytes_in_packet; bytes_remaining -= bytes_in_packet;
bytes_sent += bytes_in_packet; bytes_sent += bytes_in_packet;
} }
*/
free(data); free(data);
PrintAndLogEx(NORMAL, ""); PrintAndLogEx(NORMAL, "");
PrintAndLogEx(SUCCESS, "Done"); PrintAndLogEx(SUCCESS, "Done");
*/ return PM3_SUCCESS;
return PM3_SUCCESS;
} }
static int CmdHFCryptoRFESave(const char *Cmd) { static int CmdHFCryptoRFESave(const char *Cmd) {