From f6e013c7fc5a28166623496c2a179ac57f16b2c4 Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Fri, 13 Mar 2020 13:52:23 +0100
Subject: [PATCH] cppchecker

---
 armsrc/hitag2crack.c | 10 +++++-----
 armsrc/hitag2crack.h |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/armsrc/hitag2crack.c b/armsrc/hitag2crack.c
index 2d0d868b9..d66f740bc 100644
--- a/armsrc/hitag2crack.c
+++ b/armsrc/hitag2crack.c
@@ -300,7 +300,7 @@ bool hitag2crack_read_page(uint8_t *responsestr, uint8_t pagenum, uint8_t *nrar,
     uint8_t response[32];
     int i;
 
-    if ((pagenum < 0) || (pagenum > 7)) {
+    if (pagenum > 7) {
         UserMessage("hitag2crack_read_page:\r\n invalid pagenum\r\n");
         return false;
     }
@@ -351,7 +351,7 @@ bool hitag2crack_read_page(uint8_t *responsestr, uint8_t pagenum, uint8_t *nrar,
 // cmd is the binarray of the encrypted command to send;
 // len is the length of the encrypted command.
 bool hitag2crack_send_e_cmd(uint8_t *responsestr, uint8_t *nrar, uint8_t *cmd, int len) {
-    uint8_t tmp[37];
+//    uint8_t tmp[37];
     uint8_t uid[9];
     uint8_t e_page3str[9];
     int ret = 0;
@@ -551,14 +551,14 @@ bool hitag2_keystream(uint8_t *response, uint8_t *nrarhex) {
     uint8_t uid[32];
     uint8_t nrar[64];
     uint8_t e_firstcmd[10];
-    uint8_t e_page0cmd[10];
+//    uint8_t e_page0cmd[10];
 //    uint8_t keybits[2080];
     uint8_t *keybits = DataBuff;
     uint8_t keybitshex[67];
     int kslen;
     int ksoffset;
-    uint8_t pagehex[9];
-    uint8_t temp[20];
+//    uint8_t pagehex[9];
+//    uint8_t temp[20];
     int i;
     uint8_t *spaceptr = NULL;
 
diff --git a/armsrc/hitag2crack.h b/armsrc/hitag2crack.h
index 75fa54546..af3e41d14 100644
--- a/armsrc/hitag2crack.h
+++ b/armsrc/hitag2crack.h
@@ -19,9 +19,9 @@ bool hitag2crack_tx_rx(uint8_t *responsestr, uint8_t *msg, int len, int state, b
 
 bool hitag2crack_rng_init(uint8_t *response, uint8_t *input);
 bool hitag2crack_decrypt_hex(uint8_t *response, uint8_t *hex);
-bool hitag2crack_decrypt_bin(uint8_t *response, uint8_t *hex);
+bool hitag2crack_decrypt_bin(uint8_t *response, uint8_t *e_binstr);
 bool hitag2crack_encrypt_hex(uint8_t *response, uint8_t *hex);
-bool hitag2crack_encrypt_bin(uint8_t *response, uint8_t *hex);
+bool hitag2crack_encrypt_bin(uint8_t *response, uint8_t *e_binstr);
 
 bool hitag2_keystream(uint8_t *response, uint8_t *nrarhex);
 bool hitag2crack_send_auth(uint8_t *nrar);